Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate secp256k1 0.28 and 0.29 #8210

Closed
DaniPopes opened this issue May 12, 2024 · 1 comment · Fixed by bluealloy/revm#1490
Closed

Deduplicate secp256k1 0.28 and 0.29 #8210

DaniPopes opened this issue May 12, 2024 · 1 comment · Fixed by bluealloy/revm#1490
Labels
A-dependencies Pull requests or issues that are about dependencies C-enhancement New feature or request

Comments

@DaniPopes
Copy link
Member

DaniPopes commented May 12, 2024 •
edited
Loading

Describe the feature

secp256k1 0.29 was added with the recent revm bump to 9.0 (#7765)
This compiles the C library twice

Additional context

No response
@DaniPopes DaniPopes added C-enhancement New feature or request A-dependencies Pull requests or issues that are about dependencies labels May 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Jun 3, 2024
@onbjerg onbjerg removed the S-stale This issue/PR is stale and will close with no further activity label Jun 3, 2024
@DaniPopes DaniPopes mentioned this issue Jun 5, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-dependencies Pull requests or issues that are about dependencies C-enhancement New feature or request
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(deps): allow multiple versions of secp256k1 DaniPopes/revm
2 participants
@onbjerg @DaniPopes