Passing AWS credentials Deprecation Notice

[montymxb]

Noticed the following deprecation notice in our tests.

• AdapterLoader should load S3Adapter from direct passing
  • Passing AWS credentials to this adapter is now DEPRECATED and will be removed in a future version See: https://github.com/parse-server-modules/parse-server-s3-adapter#aws-credentials for details

The test being in AdapterLoader.spec.js

it("should load S3Adapter from direct passing", (done) => {
  var s3Adapter = new S3Adapter("key", "secret", "bucket")
  expect(() => {
    var adapter = loadAdapter(s3Adapter, FilesAdapter);
    expect(adapter).toBe(s3Adapter);
  }).not.toThrow();
  done();
})

We'll need to correct this before it's removed and potentially breaks the tests.

[decoyfox]

seeing this issue as well

[flovilmart]

@decoyfox, it’s not an issue, you should follow the instructions as the original behavior will be removed soon.

[duffek]

@montymxb you probably want to see this open question: parse-community/parse-server-s3-adapter#52 and this stack overflow post if you are using Heroku: https://stackoverflow.com/questions/45696859/parse-server-s3-adapter-deprecated/47518360

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.