Skip to content
This repository was archived by the owner on Dec 10, 2019. It is now read-only.

Cache Buster not outputting. #56

Closed
brianjhanson opened this issue Jul 5, 2016 · 5 comments
Closed

Cache Buster not outputting. #56

brianjhanson opened this issue Jul 5, 2016 · 5 comments

Comments

@brianjhanson
Copy link

brianjhanson commented Jul 5, 2016

I am using Pattern Lab Node v6.2.0 on Mac, using the gulp configuration.

Expected Behavior

{{ cacheBuster }} should output the current time in the head and foot mustache templates.

Actual Behavior

{{ cacheBuster }} doesn't output anything.

Steps to Reproduce

Download pre-built gulp edition and get it running, make sure the cacheBust setting is set to true. Nothing is output behind the ? of the stylesheets in the head.

It seems like this variable isn't getting provided to the actual template, it's working properly in {{{ patternLabHead }}} section.

@bmuenzenmeyer
Copy link
Member

Confirmed, thanks for finding this

@brianjhanson
Copy link
Author

Tried to fix this guy, figured out that the buster is outputting correctly on single pattern pages just not on the "all" page. Haven't quite figured out why that would be yet though.

@bmuenzenmeyer
Copy link
Member

bmuenzenmeyer commented Jul 27, 2016

Fixed this by adding cacheBuster: patternlab.cacheBuster to https://github.com/pattern-lab/patternlab-node/blob/master/core/lib/ui_builder.js#L452

will patch tonight unless someone else gets to it

@bmuenzenmeyer
Copy link
Member

bmuenzenmeyer commented Jul 29, 2016

@brianjhanson could you change your package.json patternlab-node version to:

"patternlab-node": "pattern-lab/patternlab-node#dev"

and retest?

@brianjhanson
Copy link
Author

🎉 seems to be working over here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants