Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underscore-hidden patterns must be callable by shorthand partial style #469

Closed
3 tasks
geoffp opened this issue Sep 2, 2016 · 2 comments
Closed
3 tasks

Comments

@geoffp
Copy link
Contributor

geoffp commented Sep 2, 2016

I am using Pattern Lab Node v2.5.1 on Mac, with Node 4.4.7, using the Gulp Edition.

In Handlebars, and possibly other engines, we are currently off-spec with our handling of callable patterns hidden by underscore-prefix.

Expected Behavior

Given a Mustache pattern at atoms/00-somegroup/_00-foo.mustache I should be able to call it as {{> atoms-foo}}.

Actual Behavior

I believe one could call this underscored pattern partial today, but you'd have to call it in the nasty longform way, as in: {{> atoms-_00-foo}}. This is the recommended workaround until we change to the correct way.

TODO:

  • Reproduce and fix if necessary in Handlebars
  • Reproduce and fix if necessary in Underscore
  • Reproduce and fix if necessary in Twig
@geoffp
Copy link
Contributor Author

geoffp commented Oct 5, 2016

UPDATE: this works with Mustache! The only two reports of this have been in Handlebars templates!

@geoffp
Copy link
Contributor Author

geoffp commented Oct 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants