Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests/ to npmignore file #588

Closed
bmuenzenmeyer opened this issue Jan 9, 2017 · 2 comments · Fixed by #591
Closed

Add tests/ to npmignore file #588

bmuenzenmeyer opened this issue Jan 9, 2017 · 2 comments · Fixed by #591

Comments

@bmuenzenmeyer
Copy link
Member

bmuenzenmeyer commented Jan 9, 2017

Raphael clued me in on https://docs.npmjs.com/misc/developers#keeping-files-out-of-your-package which we should most definintely be doing for tests/ as normal consumers have no reason to get these files during distribution.

@raphaelokon
Copy link
Contributor

raphaelokon commented Jan 9, 2017

Or add files: ['core/'] to package.json to exclude all explicitly and only include /core into the package :)

@raphaelokon
Copy link
Contributor

Reference here: https://docs.npmjs.com/files/package.json#files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants