Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using underscore to hide pattern folder cause critical error in Windows environment #596

Closed
carlosliu opened this issue Jan 18, 2017 · 2 comments
Closed

Using underscore to hide pattern folder cause critical error in Windows environment #596

carlosliu opened this issue Jan 18, 2017 · 2 comments
Assignees
@bmuenzenmeyer @tburny
Labels
bug 🐛 fix / refactor 🚧

Comments

@carlosliu
Copy link
Contributor

I am using Pattern Lab Node v2.7.2 on Windows | Mac | Linux, with Node v4.7.2, using the Gulp Edition.

Expected Behavior

Putting underscore as the first character of a pattern directory name, such as 00-atoms\_00-blah, should exclude _00-blah from the library.

Actual Behavior

It throw following critical error
Could not find patternType 00-atoms-00-atoms. This is a critical error.
@carlosliu carlosliu mentioned this issue Jan 18, 2017
Merged
@tburny
Copy link

tburny commented Jan 18, 2017

@bmuenzenmeyer Looks good, cannot merge this myself.

@bmuenzenmeyer
Copy link
Member

this is released with 2.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmuenzenmeyer bmuenzenmeyer

@tburny tburny

Labels
bug 🐛 fix / refactor 🚧
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@carlosliu @bmuenzenmeyer @tburny