Skip to content

Commit b82a59a

Browse files
fix: url fetch error
1 parent 3f5f53d commit b82a59a

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

src/services/SendReleaseDeploymentStatusService.spec.ts

+2-8
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ describe('SendReleaseDeploymentStatusService', () => {
3030

3131
const resource = {
3232
environment: {
33-
name: 'some-env-name',
33+
name: process.env.ENVIRONMENT_NAME,
3434
status: 'succeeded',
3535
releaseDefinition: {
3636
name: process.env.ENVIRONMENT_RELEASE_NAME,
@@ -60,7 +60,7 @@ describe('SendReleaseDeploymentStatusService', () => {
6060

6161
const resource = {
6262
environment: {
63-
name: 'some-env-name',
63+
name: process.env.ENVIRONMENT_NAME,
6464
status: 'failed',
6565
releaseDefinition: {
6666
name: process.env.ENVIRONMENT_RELEASE_NAME,
@@ -71,15 +71,9 @@ describe('SendReleaseDeploymentStatusService', () => {
7171
const setTitleSpy = jest.spyOn(fakeMessageEmbed, 'setTitle');
7272
const webhookSend = jest.spyOn(fakeWebhookClient, 'send');
7373

74-
const getURL = jest
75-
// @ts-expect-error Jest use case
76-
.spyOn<any>(sendReleaseBuildStatus, 'getURL')
77-
.mockImplementationOnce(() => 'some-url');
78-
7974
await sendReleaseBuildStatus.execute({ message, resource });
8075

8176
expect(setTitleSpy).toHaveBeenCalled();
8277
expect(webhookSend).toHaveBeenCalled();
83-
expect(getURL).toHaveBeenCalled();
8478
});
8579
});

src/services/SendReleaseDeploymentStatusService.ts

+4-2
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,6 @@ export class SendReleaseDeploymentStatusService {
4747

4848
const { name: releaseName } = releaseDefinition;
4949

50-
const url = await this.getURL(environment);
51-
5250
const embed = this.messageEmbed
5351
.setTitle(releaseName)
5452
.setDescription(message.markdown)
@@ -58,6 +56,7 @@ export class SendReleaseDeploymentStatusService {
5856
releaseName === process.env.ENVIRONMENT_RELEASE_NAME &&
5957
status === 'succeeded'
6058
) {
59+
const url = await this.getURL(environment);
6160
embed.addField('Deployment URL', url);
6261
}
6362

@@ -72,6 +71,9 @@ export class SendReleaseDeploymentStatusService {
7271
data: { deployments },
7372
} = await axios.get(axiosURL);
7473

74+
if (!deployments)
75+
throw new Error('Vercel API does not returned any value');
76+
7577
const { url }: IDeployPayload = deployments.find(
7678
(deploy: IDeployPayload) => deploy.name === process.env.DEPLOY_NAME,
7779
);

0 commit comments

Comments
 (0)