Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate cutoff_frequency for ES7 #118

Closed
orangejulius opened this issue Jan 18, 2020 · 2 comments · Fixed by #134
Closed

Deprecate cutoff_frequency for ES7 #118

orangejulius opened this issue Jan 18, 2020 · 2 comments · Fixed by #134

Comments

@orangejulius
Copy link
Member

Looking at the deprecation logs for a running ES7 cluster, the only messages are the following:

[2020-01-16T23:20:05,749][WARN ][o.e.d.c.ParseField       ] Deprecated field [cutoff_frequency] used, replaced by [you can omit this option, the [multi_match] query can skip block of documents efficiently if the total number of hits is not tracked]
[2020-01-16T23:20:23,850][WARN ][o.e.d.c.ParseField       ] Deprecated field [cutoff_frequency] used, replaced by [you can omit this option, the [match] query can skip block of documents efficiently if the total number of hits is not tracked]

Looks like after all the work we did to use cutoff_frequency, it's basically no longer needed in ES7. We might as well remove it if we get the chance.

@missinglink
Copy link
Member

related #134

@missinglink
Copy link
Member

missinglink commented Apr 18, 2024

we introduced this in pelias/api#1213, however since elasticsearch 7, the equivalent behaviour of cutoff_frequency is handled internally without configuration.

just wanted to check this was safe to remove and the answer is yes, es6 and below will suffer a perf regression but we no longer support those versions so it's safe to remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants