Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progressive Web App (PWA) #68

Closed
tisto opened this issue Jan 21, 2018 · 10 comments
Closed

Progressive Web App (PWA) #68

tisto opened this issue Jan 21, 2018 · 10 comments

Comments

@tisto
Copy link
Member

tisto commented Jan 21, 2018

Turn plone-react into a PWA. create-react-app now comes with a basic PWA functionality. Might be a good starting point: facebook/create-react-app#1728

@ajayns
Copy link
Contributor

ajayns commented Jan 22, 2018

I've already gone through create-react-app and its project structure. How do I move forward now? @tisto

@tisto
Copy link
Member Author

tisto commented Jan 22, 2018

@ajayns I'd recommend starting looking into what a PWA is and does. Make a list of features that you would want to implement during GSoC. You could also start looking into the PWA that comes with create-react-app and try to add new features to it.

You could also start to add some code to create-react-app to talk to plone.restapi (I have some drafts for how-tos I could provide you with if you are interested)

@ajayns
Copy link
Contributor

ajayns commented Jan 22, 2018

@tisto I've worked a with PWAs building Angular 2+ apps, think we can follow similar steps for React. I think we'll use Google's PWA Checklist along with Lighthouse in Chrome to set goals and properly implement it.

Yes I've started exploring create-react-app and the plone.restapi. But then the restapi still seems vague to me when I think of how to use it to feed data to the PWA. Anything you can provide would really help!

@tisto
Copy link
Member Author

tisto commented Jan 22, 2018

@ajayns I started to write some tutorials here: https://github.com/kitconcept/plone.restapi-react-tutorial

They are not finished but I guess you could try to follow them and let me know if you run into problems. Feel free to report issues directly in the repo.

@ajayns
Copy link
Contributor

ajayns commented Jan 22, 2018

@tisto Okay that's great! I will look into it, thanks!

@nileshgulia1
Copy link
Member

Hey @tisto , What's the status of the work on this :)

@ajayns
Copy link
Contributor

ajayns commented Feb 6, 2018

@nileshgulia1 Hey! No work has yet been started yet on this, but you can explore the repo itself and also take a look in the plone docs for how it works and so on.

@stevepiercy
Copy link
Collaborator

@tisto we just had a first-timer open a PR because this issue is open. Do we even want to do this anymore?

@sneridagh
Copy link
Member

@stevepiercy We had a GSOC in 2018 about this, but it never made it into core.
See: #1196
and my last comment.
This was finally uninteresting to the community. The amount of hours spent were big GSOC project-like, so anything that comes behind should be based on @iFlameing work, and it's not trivial, so if someone wants to really resurect it is because they really have business interest in this to happen (which, again, the community didn't in the last 6 years).

I'd say let's close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants