Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include stack trace in errors #5660

Open
waldekmastykarz opened this issue Nov 10, 2023 · 4 comments · May be fixed by #5758
Open

Include stack trace in errors #5660

waldekmastykarz opened this issue Nov 10, 2023 · 4 comments · May be fixed by #5758
Assignees
@nicodecleyre
Labels
enhancement work in progress

Comments

@waldekmastykarz
Copy link
Member

To simplify debugging errors we should include stack trace. Along with the command it should make it easier for us to find and fix bugs.
@waldekmastykarz waldekmastykarz added enhancement needs peer review Needs second pair of eyes to review the spec or PR labels Nov 10, 2023
@waldekmastykarz
Copy link
Member Author

@pnp/cli-for-microsoft-365-maintainers thoughts?

@martinlingstuyl
Copy link
Contributor

Fully agreed. Maybe add this when using --debug?

@waldekmastykarz waldekmastykarz added help wanted and removed needs peer review Needs second pair of eyes to review the spec or PR labels Nov 11, 2023
@nicodecleyre
Copy link
Contributor

Can I work on this? Just to be sure, stack trace only when using --debug?

@Jwaegebaert
Copy link
Contributor

Yes @nicodecleyre, the idea would be to only include it during --debug.

@nicodecleyre nicodecleyre linked a pull request Jan 5, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicodecleyre nicodecleyre

Labels
enhancement work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include stack trace in errors, Closes #5660 nicodecleyre/cli-microsoft365
4 participants
@martinlingstuyl @waldekmastykarz @nicodecleyre @Jwaegebaert