Skip to content

Commit 200f2d1

Browse files
committed
add linters
1 parent 4d0bcd0 commit 200f2d1

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

.github/workflows/main.yml

+6-3
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,15 @@ on:
1616

1717
env:
1818
# Even though we can test against multiple versions, this one is considered a target version.
19-
TARGET_GOLANG_VERSION: "1.18"
19+
TARGET_GOLANG_VERSION: "1.19"
2020
PROTOC_VERSION: "3.19.4"
2121

2222
jobs:
2323
test-multiple-go-versions:
2424
runs-on: ubuntu-latest
2525
strategy:
2626
matrix:
27-
go: ["1.18"] # As we are relying on generics, we can't go lower than 1.18.
27+
go: ["1.18", "1.19"] # As we are relying on generics, we can't go lower than 1.18.
2828
fail-fast: false
2929
name: Go ${{ matrix.go }} test
3030
steps:
@@ -58,7 +58,10 @@ jobs:
5858
uses: guyarb/[email protected]
5959
with:
6060
test-results: test_results.json
61-
61+
- name: Run static check
62+
# Only run if the test failed on target version to avoid duplicated annotations on GitHub.
63+
if: ${{ always() && env.TARGET_GOLANG_VERSION == matrix.go }}
64+
uses: reviewdog/action-staticcheck@v1
6265
# TODO(@okdas): move coverage to a separate job
6366
- name: create coverage report
6467
if: ${{ env.TARGET_GOLANG_VERSION == matrix.go }}

0 commit comments

Comments
 (0)