Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Utility] CLI Usage instructions and specification #193

Closed
9 tasks done
deblasis opened this issue Sep 7, 2022 · 4 comments
Closed
9 tasks done

[Utility] CLI Usage instructions and specification #193

deblasis opened this issue Sep 7, 2022 · 4 comments
Assignees
Labels
client work needed to interface with the node (rpc, cli, etc..) core Core infrastructure - protocol related documentation Improvements or additions to documentation tooling tooling to support development, testing et al utility Utility specific changes

Comments

@deblasis
Copy link
Contributor

deblasis commented Sep 7, 2022

Objective

Write a User Usage and a specification documenting the CLI features, quirks and whatnot, extending what has been (or not) already written in the CLI README (app/client/cli/doc/README.md)

This issue builds on top of #169 (in case it hasn't been merged into main at the time of reading)

Origin Document

The CLI is going to be a multipurpose tool used by several personas interacting with Pocket Network.
We need a clear, detailed but concise document that covers the basics and HOWTOs when using and also developing/extending the CLI.

Goals

  • Provide enough context and information so that all the basics and the foresaw FAQs about the CLI are covered.

Deliverable

  • A good CLI should be user-friendly and its use should feel natural. This means that the inline help provided by the CLI (Cobra) is also part of the documentation (for the user usage part)
  • The specifications should also cover a top-down description of the architecture of the module
  • Updated app/client/cli/doc/README.md

Non-goals / Non-deliverables

  • Do not cover the RPC spec since it's considered an implementation detail that might change and it's however documented in the relevant module.

General issue deliverables

  • Update the appropriate CHANGELOG
  • Update any relevant READMEs (local and/or global)
  • Update any relevant global documentation & references
  • If applicable, update the source code tree explanation
  • If applicable, add or update a state, sequence or flowchart diagram using mermaid

[Optional] Testing Methodology

  • Task specific tests: make ...
  • All tests: make test_all
  • LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md

Creator: @deblasis
Co-Owners: ??

@deblasis deblasis added utility Utility specific changes priority:medium tooling tooling to support development, testing et al core Core infrastructure - protocol related client work needed to interface with the node (rpc, cli, etc..) labels Sep 7, 2022
@deblasis deblasis changed the title [Utility] CLI Usage instructions [Utility] CLI Usage instructions and specification Sep 7, 2022
@Olshansk Olshansk moved this to Up Next in V1 Dashboard Sep 8, 2022
@deblasis
Copy link
Contributor Author

deblasis commented Sep 9, 2022

First stab here e5c3ae5

I think that the .md files should not be gitignored and that instead should be refreshed automatically anytime we merge a PR that has changes in the CLI folder... it can be achieved by playing with git in github workflows.

For now, I guess that we could do this manually... every time we update the CLI, we need to regenerate the docs via

make generate_cli_commands_docs

image

@deblasis deblasis added the documentation Improvements or additions to documentation label Sep 9, 2022
@jessicadaugherty jessicadaugherty changed the title [Utility] CLI Usage instructions and specification [Tooloing] CLI Usage instructions and specification Oct 3, 2022
@jessicadaugherty jessicadaugherty changed the title [Tooloing] CLI Usage instructions and specification [Tooling] CLI Usage instructions and specification Oct 3, 2022
@jessicadaugherty jessicadaugherty moved this from Up Next to In Progress in V1 Dashboard Oct 5, 2022
@jessicadaugherty jessicadaugherty changed the title [Tooling] CLI Usage instructions and specification [Utility] CLI Usage instructions and specification Oct 18, 2022
@jessicadaugherty
Copy link
Contributor

jessicadaugherty commented Oct 19, 2022

Refactor against #235, which has been merged to main

@jessicadaugherty jessicadaugherty moved this from In Progress to In Review in V1 Dashboard Nov 2, 2022
@deblasis
Copy link
Contributor Author

@Olshansk I believe this can be closed as part of #112 (since I have added the docs generator), do you agree or do you feel like there's more work to do here?

@Olshansk
Copy link
Member

@Olshansk I believe this can be closed as part of #112 (since I have added the docs generator), do you agree or do you feel like there's more work to do here?

💯% agreed!

Repository owner moved this from In Review to Done in V1 Dashboard Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client work needed to interface with the node (rpc, cli, etc..) core Core infrastructure - protocol related documentation Improvements or additions to documentation tooling tooling to support development, testing et al utility Utility specific changes
Projects
Status: Done
Development

No branches or pull requests

3 participants