-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Utility] CLI - Non custodial Staking command #194
Comments
Considering for bounty. LMK of any objections @Olshansk |
The only thing to keep in mind is that the current custodial/non-custodial design is very v0-centric (1 address, 1 output, very limited), and I don't think this is a major priority for TestNet. With all of @h5law's work, this should be relatively straightforward to add, but I would also classify it as low priority. Personally, I think we can move this out into M5, and potentially start collecting what custodial/non-custodial should look like first (who can sign what, rev-share, multiple output address, etc...). |
Thanks @Olshansk agreed re: not a priority for testnet. I am looking for a task to get a contributor onboarded and started. They are a node runner so thought this would be a good one for them. Can ask their thoughts about future enhancements. I updated the deliverables to include optional "non-custodial enhancements" documented in the PR for this. Will use that for foundational conversations with larger node-running community. Also if you have another ticket that is good for onboarding someone but is a higher priority I'm happy to move forward with that instead. |
@Anaski99 do you still plan on tackling this? |
I don't think so, no available bandwidth right now :( |
This will be revisited as part of the E2E utility flows. |
Objective
As implemented in #177, the CLI supports only
Custodial
staking. We need to supportNon Custodial
as well.Origin Document
This comment:
Two separate subcommands - Can you create a follow-up issue to add support for non-custodial CLI support to avoid increasing the scope of this PR.
Goals
NonCustodial
subcommand under theStake
commandMessageStake
has all the necessary fields to supportNonCustodial
staking and that you are assigning the right values to themDeliverable
Non-goals / Non-deliverables
General issue deliverables
[Optional] Testing Methodology
make ...
make test_all
LocalNet
is still functioning correctly by following the instructions at docs/development/README.mdCreator: @deblasis
Co-Owners: @jessicadaugherty
The text was updated successfully, but these errors were encountered: