Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Utility] CLI - Non custodial Staking command #194

Closed
10 tasks
deblasis opened this issue Sep 7, 2022 · 6 comments
Closed
10 tasks

[Utility] CLI - Non custodial Staking command #194

deblasis opened this issue Sep 7, 2022 · 6 comments
Labels
client work needed to interface with the node (rpc, cli, etc..) community Open to or owned by a non-core team member core starter task Good for newcomers, but aimed at core team members though still open for everyone core Core infrastructure - protocol related tooling tooling to support development, testing et al

Comments

@deblasis
Copy link
Contributor

deblasis commented Sep 7, 2022

Objective

As implemented in #177, the CLI supports only Custodial staking. We need to support Non Custodial as well.

Origin Document

This comment:
Two separate subcommands - Can you create a follow-up issue to add support for non-custodial CLI support to avoid increasing the scope of this PR.

Goals

  • Include a NonCustodial subcommand under the Stake command
  • Identify the required arguments by referencing the V0 implementation
  • Make sure that the MessageStake has all the necessary fields to support NonCustodial staking and that you are assigning the right values to them

Deliverable

  • Updated CLI with non-custodial staking command
  • (optional) recommendations for non-custodial enhancements documented on the PR of this issue

Non-goals / Non-deliverables

  • Adding in additional stake commands
  • Changing the behavior of non-custodial staking
  • Updating the RPC

General issue deliverables

  • Update the appropriate CHANGELOG
  • Update any relevant READMEs (local and/or global)
  • Update any relevant global documentation & references
  • If applicable, update the source code tree explanation
  • If applicable, add or update a state, sequence or flowchart diagram using mermaid

[Optional] Testing Methodology

  • Task specific tests: make ...
  • All tests: make test_all
  • LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md

Creator: @deblasis
Co-Owners: @jessicadaugherty

@deblasis deblasis added core Core infrastructure - protocol related priority:medium tooling tooling to support development, testing et al client work needed to interface with the node (rpc, cli, etc..) labels Sep 7, 2022
@Olshansk Olshansk moved this to TODO in V1 Dashboard Sep 7, 2022
@Olshansk Olshansk added the core starter task Good for newcomers, but aimed at core team members though still open for everyone label Dec 15, 2022
@jessicadaugherty
Copy link
Contributor

Considering for bounty. LMK of any objections @Olshansk

@Olshansk
Copy link
Member

Considering for bounty. LMK of any objections @Olshansk

The only thing to keep in mind is that the current custodial/non-custodial design is very v0-centric (1 address, 1 output, very limited), and I don't think this is a major priority for TestNet.

With all of @h5law's work, this should be relatively straightforward to add, but I would also classify it as low priority.

Personally, I think we can move this out into M5, and potentially start collecting what custodial/non-custodial should look like first (who can sign what, rev-share, multiple output address, etc...).

@jessicadaugherty
Copy link
Contributor

jessicadaugherty commented Feb 20, 2023

Thanks @Olshansk agreed re: not a priority for testnet. I am looking for a task to get a contributor onboarded and started. They are a node runner so thought this would be a good one for them. Can ask their thoughts about future enhancements. I updated the deliverables to include optional "non-custodial enhancements" documented in the PR for this. Will use that for foundational conversations with larger node-running community. Also if you have another ticket that is good for onboarding someone but is a higher priority I'm happy to move forward with that instead.

@jessicadaugherty jessicadaugherty added the community Open to or owned by a non-core team member label Feb 20, 2023
@jessicadaugherty jessicadaugherty moved this from Backlog to Up Next in V1 Dashboard Feb 22, 2023
@jessicadaugherty jessicadaugherty moved this from Up Next to In Progress in V1 Dashboard Mar 20, 2023
@Olshansk
Copy link
Member

@Anaski99 do you still plan on tackling this?

@Anaski99
Copy link

I don't think so, no available bandwidth right now :(

@Olshansk
Copy link
Member

This will be revisited as part of the E2E utility flows.

@github-project-automation github-project-automation bot moved this from In Progress to Done in V1 Dashboard Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client work needed to interface with the node (rpc, cli, etc..) community Open to or owned by a non-core team member core starter task Good for newcomers, but aimed at core team members though still open for everyone core Core infrastructure - protocol related tooling tooling to support development, testing et al
Projects
Status: Done
Development

No branches or pull requests

4 participants