[Automation] CI checks for cross-module dependencies

[Olshansk]

Objective

Use custom CI linter checks to avoid cross-module dependencies.

Origin Document

Even though the Pocket Network V1 implementation is a monolith that will shares artifacts, helpers, interfaces, structures, etc, across different modules, we want to avoid explicit dependency of one module on another and facilitate that communication via the application-specific bus.

In #235, the following conversation came up:

While we don't want to enable these linters right now, we want to enable them in the future.

Some examples include:

grep --exclude-dir='./persistence' -r "github.com/pokt-network/pocket/persistence"
grep --exclude-dir='./consensus' -r "github.com/pokt-network/pocket/consensus"
...

Goals

• Enable automated ways of raising warnings on or blocking explicit cross-module (i.e. not via the application-specific bus)

Deliverable

• Infrastructure that enables general-purpose linters based on the output of a bash command
• Documentation on how to add additional lintesr to the above

Non-goals / Non-deliverables

• Enable these linters in mainline today

General issue deliverables

• Update the appropriate CHANGELOG
• Update any relevant READMEs (local and/or global)
• Update any relevant global documentation & references

---

Creator: @olshansky
Co-Owners: @okdas

[Olshansk]

Adding a few more to the list as our custom linter checks:

• Using any instead of interface{} -> needs to be changes
• Check if #XXX issue closed when trying to merge in a PR -> needs to be deleted
• Avoid using proto directly outside the codec package in favour of coded.GetCodec()
• Block merge if IN_THIS_COMMIT is present in the code

[Olshansk]

Closing this out as unplanned for the foreseeable future. Ticket can be reopened if/when needed.