Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECHDEBT] [P2P] Raintree test suite improvements: Add configurations tests for dead and partially visible nodes #276

Open
7 tasks
deblasis opened this issue Oct 3, 2022 · 2 comments
Assignees
Labels
core starter task Good for newcomers, but aimed at core team members though still open for everyone p2p P2P specific changes

Comments

@deblasis
Copy link
Contributor

deblasis commented Oct 3, 2022

Objective

Tend to this TODO:

./p2p/module_raintree_test.go:// TODO(olshansky): Add configurations tests for dead and partially visible nodes

Clarify scope and update below

Origin Document

[ Why? Issue justification and/or link to another document]

Goals

  • _REPLACE_ME: List of things that are high level ideas or goals driving the task
  • ...

Deliverable

  • _REPLACE_ME: List of things that are concrete deliverables
  • ...

Non-goals / Non-deliverables

  • _REPLACE_ME: List of things that are out of scope
  • ...

General issue deliverables

  • Update the appropriate CHANGELOG
  • Update any relevant READMEs (local and/or global)
  • Update any relevant global documentation & references
  • If applicable, update the source code tree explanation
  • If applicable, add or update a state, sequence or flowchart diagram using mermaid

[Optional] Testing Methodology

  • _REPLACE_ME: Make sure to update the testing methodology appropriately_
  • Task specific tests: make ...
  • All tests: make test_all
  • LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md

Creator: @deblasis
Co-Owners: @Olshansk

@deblasis deblasis added the p2p P2P specific changes label Oct 3, 2022
@deblasis deblasis self-assigned this Oct 3, 2022
@Olshansk Olshansk moved this to Backlog in V1 Dashboard Oct 3, 2022
@Olshansk
Copy link
Member

Olshansk commented Oct 5, 2022

This is blocked by #179, but once 179 is in, the goal is to update the testing suite to support the following test case:

Screen Shot 2022-10-05 at 11 19 39 AM

@Olshansk Olshansk removed the triage It requires some decision-making at team level (it can't be worked on as it stands) label Oct 5, 2022
@Olshansk
Copy link
Member

Olshansk commented Nov 9, 2022

@andrewnguyen22 Is this something you're working on as part of RainTree cleanup & redundancy?

@Olshansk Olshansk added the core starter task Good for newcomers, but aimed at core team members though still open for everyone label Dec 15, 2022
@bryanchriswhite bryanchriswhite moved this from Backlog to Rescope in V1 Dashboard Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core starter task Good for newcomers, but aimed at core team members though still open for everyone p2p P2P specific changes
Projects
Status: Rescope
Development

No branches or pull requests

3 participants