Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shared] Config and Genesis refactoring improvement: Consider renaming NodeModules #292

Closed
7 tasks
deblasis opened this issue Oct 6, 2022 · 2 comments
Closed
7 tasks
Assignees
Labels
code health Nice to have code improvement core Core infrastructure - protocol related

Comments

@deblasis
Copy link
Contributor

deblasis commented Oct 6, 2022

Objective

Keep track and address areas of improvement. Specifically, in this issue we aim at addressing the comments below (which are related)

Related PR #235

Origin Document

Goals

  • Code quality

Deliverable

  • Understood and agreed upon implementation

Non-goals / Non-deliverables

  • Any change in logic

General issue deliverables

  • Update the appropriate CHANGELOG
  • Update any relevant READMEs (local and/or global)
  • Update any relevant global documentation & references
  • If applicable, update the source code tree explanation
  • If applicable, add or update a state, sequence or flowchart diagram using mermaid

[Optional] Testing Methodology

  • _REPLACE_ME: Make sure to update the testing methodology appropriately_
  • Task specific tests: make ...
  • All tests: make test_all
  • LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md

Creator: @deblasis
Co-Owners: @Olshansk

@deblasis deblasis added the code health Nice to have code improvement label Oct 6, 2022
@deblasis deblasis added the core Core infrastructure - protocol related label Oct 6, 2022
@Olshansk Olshansk moved this to Backlog in V1 Dashboard Oct 6, 2022
@Olshansk
Copy link
Member

Olshansk commented Dec 15, 2022

@deblasis Figured this could be done in parallel with the config refactoring. I didn't dive into the context so there's a chance it can be closed as a duplicate.

@deblasis
Copy link
Contributor Author

deblasis commented Dec 15, 2022

@Olshansk: This has been addressed already and I forgot to close it.

We discussed the concept of NodeModule in #235 (that I had introduced) but then in code-review we agreed it was unnecessary so I removed it.

Repository owner moved this from Backlog to Done in V1 Dashboard Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Nice to have code improvement core Core infrastructure - protocol related
Projects
Status: Done
Development

No branches or pull requests

2 participants