Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P2P] Define outstanding parameters & reasonable defaults #629

Open
9 tasks
bryanchriswhite opened this issue Mar 28, 2023 · 1 comment
Open
9 tasks

[P2P] Define outstanding parameters & reasonable defaults #629

bryanchriswhite opened this issue Mar 28, 2023 · 1 comment
Assignees
Labels
code health Nice to have code improvement core starter task Good for newcomers, but aimed at core team members though still open for everyone p2p P2P specific changes

Comments

@bryanchriswhite
Copy link
Contributor

Objective

Support configuration of any new degrees of freedom introduced by or since libp2p integration.

Origin Document

image

Out of scope for #553.

Goals

  • Address outstanding // TECHDEBT in the P2P regarding values which should be parameterized
  • Determine what "reasonable" defaults are for each

Deliverable

  • Add missing P2P config fields
  • Ensure defaults are defined in runtime/defaults/defaults.go

Non-goals / Non-deliverables

  • Addressing additional // TECHDEBT comments or refactoring outside the scope of updating the P2P config

General issue deliverables

  • Update the appropriate CHANGELOG(s)
  • Update any relevant local/global README(s)
  • Update relevant source code tree explanations
  • Add or update any relevant or supporting mermaid diagrams

Testing Methodology

  • Task specific tests or benchmarks: Tests should exercise new config fields
  • All tests: make test_all
  • LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md

Creator: @bryanchriswhite

@bryanchriswhite bryanchriswhite added the p2p P2P specific changes label Mar 28, 2023
@Olshansk Olshansk moved this to Up Next in V1 Dashboard Mar 28, 2023
@Olshansk Olshansk added the core starter task Good for newcomers, but aimed at core team members though still open for everyone label Mar 28, 2023
@Olshansk Olshansk moved this from Up Next to Backlog in V1 Dashboard Mar 28, 2023
@Olshansk
Copy link
Member

@bryanchriswhite I added the core starter task label to this since it's not something we need to do immediately, but could be a great first task to future team members.

@Olshansk Olshansk added the code health Nice to have code improvement label Apr 19, 2023
@Olshansk Olshansk self-assigned this Jul 3, 2023
@Olshansk Olshansk removed their assignment Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Nice to have code improvement core starter task Good for newcomers, but aimed at core team members though still open for everyone p2p P2P specific changes
Projects
Status: Backlog
Development

No branches or pull requests

3 participants