Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P2P] Host/port shouldn't be required in client debug mode #678

Open
7 tasks
bryanchriswhite opened this issue Apr 14, 2023 · 1 comment
Open
7 tasks

[P2P] Host/port shouldn't be required in client debug mode #678

bryanchriswhite opened this issue Apr 14, 2023 · 1 comment
Assignees
Labels
bug Something isn't working - expected behaviour is incorrect community Open to or owned by a non-core team member core starter task Good for newcomers, but aimed at core team members though still open for everyone p2p P2P specific changes triage It requires some decision-making at team level (it can't be worked on as it stands)

Comments

@bryanchriswhite
Copy link
Contributor

bryanchriswhite commented Apr 14, 2023

Objective

Improve user experience of the debug CLI.

Origin Document

image

Goals

  • Debug CLI command is usable when hostname and port P2P config fields are absent or empty string

Deliverable

  • Update P2P module #Create() logic to set m.listenAddrs = libp2p.NoListenAddrs if isClientDebugMode (regardless of `m.cfg.ConnectionType)
  • Remove POCKET_P2P_HOSTNAME env var from cli-client.yaml manifest
  • Fix resulting or related bugs and/or errors

Non-goals / Non-deliverables

  • Modifying the P2P config
  • Modifying Network implementations

General issue deliverables

  • Update the appropriate CHANGELOG(s)
  • Update any relevant local/global README(s)
  • Update relevant source code tree explanations
  • Add or update any relevant or supporting mermaid diagrams

Testing Methodology

TODO

  • All tests: make test_all
  • LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md
  • *k8s LocalNet: verify a k8s LocalNet is still functioning correctly by following the instructions here

Creator: [github username of the creator]
Co-Owners: [optional - github usernames of the co-owner(s)]

@bryanchriswhite bryanchriswhite added bug Something isn't working - expected behaviour is incorrect p2p P2P specific changes starter task triage It requires some decision-making at team level (it can't be worked on as it stands) labels Apr 14, 2023
@bryanchriswhite bryanchriswhite moved this to Backlog in V1 Dashboard Apr 14, 2023
@bryanchriswhite bryanchriswhite changed the title [WIP] [P2P] Hostname shoudn't be required in client debug mode [WIP] [P2P] Host/port shouldn't be required in client debug mode Apr 14, 2023
@jessicadaugherty jessicadaugherty added community Open to or owned by a non-core team member core starter task Good for newcomers, but aimed at core team members though still open for everyone labels Apr 17, 2023
@jessicadaugherty jessicadaugherty changed the title [WIP] [P2P] Host/port shouldn't be required in client debug mode [P2P] Host/port shouldn't be required in client debug mode Apr 17, 2023
@Olshansk
Copy link
Member

@bryanchriswhite Is this ticket stilll relevant?

@github-project-automation github-project-automation bot moved this from Backlog to Done in V1 Dashboard Jul 11, 2023
@Olshansk Olshansk reopened this Jul 11, 2023
@Olshansk Olshansk self-assigned this Jul 17, 2023
@Olshansk Olshansk assigned bryanchriswhite and unassigned Olshansk Jul 30, 2023
@Olshansk Olshansk moved this from Done to Up Next in V1 Dashboard Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working - expected behaviour is incorrect community Open to or owned by a non-core team member core starter task Good for newcomers, but aimed at core team members though still open for everyone p2p P2P specific changes triage It requires some decision-making at team level (it can't be worked on as it stands)
Projects
Status: Up Next
Development

No branches or pull requests

4 participants