You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Do you want to request a feature or report a bug?
Feature
What is the current behavior?
Some part of the API could be improved/refactored to be more clear.
What is the expected behavior?
report and reporter are too close (I mean in term of naming) and very confusing. When we talk about logging we have a logger and with a logger with can log and we log a message. In report API we should follow the same and we should rename Report to Message
reporter.report(Message.builder()......build())
when creating a child reporter we set a taskId. This is confusing too because , nowhere we have task. we assign a taskId to a reporter. I think this was just to avoid naming it reporterId which was too close to reportId. But if Report is renamed to Message using a messageId, there is no problem to have a reporterId.
[LESS IMPORTANT] Maybe also we should reuse the Message class to create the child reporter to avoid reinventing similar concept for Reporterwith kind of "tilteMessage" or "headerMessage" like:
What is the motivation / use case for changing the behavior?
Please tell us about your environment:
PowSyBl Version: ...
OS Version: ...
Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, spectrum, etc)
(if a question doesn't apply, you can delete it)
The text was updated successfully, but these errors were encountered:
Do you want to request a feature or report a bug?
Feature
What is the current behavior?
Some part of the API could be improved/refactored to be more clear.
What is the expected behavior?
Report
toMessage
Report
is renamed toMessage
using a messageId, there is no problem to have a reporterId.Message
class to create the child reporter to avoid reinventing similar concept forReporter
with kind of "tilteMessage" or "headerMessage" like:What is the motivation / use case for changing the behavior?
Please tell us about your environment:
Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, spectrum, etc)
(if a question doesn't apply, you can delete it)
The text was updated successfully, but these errors were encountered: