Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration regarding trailing commas isn't respected #41

Closed
Haroenv opened this issue Jan 9, 2018 · 4 comments
Closed

Configuration regarding trailing commas isn't respected #41

Haroenv opened this issue Jan 9, 2018 · 4 comments

Comments

@Haroenv
Copy link

Haroenv commented Jan 9, 2018 •
edited
Loading

I seem to have an infinite loop of "please add commas", "please remove commas"

https://travis-ci.org/emotion-js/emotion/builds/326929845?utm_source=github_status&utm_medium=notification

emotion-js/emotion#526

Any idea what could be the cause here?

There don't seem to be any obvious changes regarding this recently though 🙃
@lydell
Copy link
Member

lydell commented Jan 9, 2018

I cloned that repo, ran yarn and then yarn lint:check and it reported no problems. What are you up to?

@Haroenv
Copy link
Author

Haroenv commented Jan 9, 2018

so weird 🤔 it might be my setup somehow, @tkh44 also can't replicate it

@Haroenv
Copy link
Author

Haroenv commented Jan 9, 2018

It was my vscode setup somehow I think, I misread the travis output

@Haroenv Haroenv closed this as completed Jan 9, 2018
@lydell
Copy link
Member

lydell commented Jan 9, 2018

Glad you solved it! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lydell @Haroenv