-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add golangci-lint-action to the existing GitHub workflow #277
Comments
I have mentioned |
@vzamanillo Hey, thanks for your contributions to the project! The work you've been doing is really amazing. Regarding |
Hey @Ice3man543! Thank you very much! I am glad to do this. Ok let's do it! So that the development does not have any negative impact on the current repository, I will try to test locally using https://github.com/nektos/act. I will keep you informed. |
Lot of work but... :) |
Done with #278 |
golangci-lint-action It's the official GitHub action for
golangci-lint
from it's authors. The action runsgolangci-lint
and reports issues from linters.golangci-lint is a fast Go linters runner. It runs linters in parallel, uses caching, supports yaml config, has integrations with all major IDE and has dozens of linters included.
Including this action into the workflow would increment the project code quality and could prevent possible future leaks and/or failures setting a minimum of checks and rules, I think it could be very favorable.
A list of available linters on the official documentation
If we adopt this standard, we would have to first try a local installation, run the chosen linters and correct the errors to adjust the source code and establish a new starting point. We cannot adopt it without making the corrections first because it would make it difficult uploading new pull requests to collaborators.
Any thoughts?
The text was updated successfully, but these errors were encountered: