Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add golangci-lint-action to the existing GitHub workflow #277

Closed
vzamanillo opened this issue Jul 21, 2020 · 5 comments · Fixed by #278
Closed

Add golangci-lint-action to the existing GitHub workflow #277

vzamanillo opened this issue Jul 21, 2020 · 5 comments · Fixed by #278
Labels
Type: Discussion Some ideas need to be planned and disucssed to come to a strategy. Type: Enhancement Most issues will probably ask for additions or changes.

Comments

@vzamanillo
Copy link
Contributor

vzamanillo commented Jul 21, 2020

golangci-lint-action It's the official GitHub action for golangci-lint from it's authors. The action runs golangci-lint and reports issues from linters.

golangci-lint is a fast Go linters runner. It runs linters in parallel, uses caching, supports yaml config, has integrations with all major IDE and has dozens of linters included.

Including this action into the workflow would increment the project code quality and could prevent possible future leaks and/or failures setting a minimum of checks and rules, I think it could be very favorable.

A list of available linters on the official documentation

If we adopt this standard, we would have to first try a local installation, run the chosen linters and correct the errors to adjust the source code and establish a new starting point. We cannot adopt it without making the corrections first because it would make it difficult uploading new pull requests to collaborators.

Any thoughts?

@ehsandeep ehsandeep added Type: Discussion Some ideas need to be planned and disucssed to come to a strategy. Type: Enhancement Most issues will probably ask for additions or changes. labels Jul 21, 2020
@vzamanillo
Copy link
Contributor Author

I have mentioned golangci-lint-action because it is very versatile and offers the possibility to use various linters for different things, but any other mechanism to improve the quality of the code would be just as good.

@Ice3man543
Copy link
Member

@vzamanillo Hey, thanks for your contributions to the project! The work you've been doing is really amazing. Regarding golangci-lint, it's a very good idea. Let's add this to this as well as other open source projects we have. This was something we had to do however not been able to yet due to time constraints.

@vzamanillo
Copy link
Contributor Author

Hey @Ice3man543!

Thank you very much! I am glad to do this.

Ok let's do it!

So that the development does not have any negative impact on the current repository, I will try to test locally using https://github.com/nektos/act.

I will keep you informed.

@vzamanillo
Copy link
Contributor Author

Lot of work but...

lint

#278

:)

@ehsandeep
Copy link
Member

Done with #278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Discussion Some ideas need to be planned and disucssed to come to a strategy. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants