Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CronJob in k8s_types is defined under the wrong version number. #32

Closed
edwardgeorge opened this issue Aug 23, 2020 · 2 comments · Fixed by #33
Closed

CronJob in k8s_types is defined under the wrong version number. #32

edwardgeorge opened this issue Aug 23, 2020 · 2 comments · Fixed by #33

Comments

@edwardgeorge
Copy link
Contributor

CronJob in k8s_types.rs is defined as under the v1 batch api, but it does not exist in this version. It exists under v1beta1 and is not in v1.

This has the effect that if you specify .with_child(k8s_types::batch::v1::CronJob, ...) on your operator config then you get no events at all being processed, the operator appears to hang and do nothing. (which may perhaps be a separate bug?)

@psFried
Copy link
Owner

psFried commented Aug 24, 2020

the operator appears to hang and do nothing. (which may perhaps be a separate bug?)

You should see the errors in both the logs and the Prometheus metrics. Additionally, the health check endpoint should report an unhealthy status since the initial state could never be determined. If any of those things aren't working, then I'd definitely appreciate a bug report.

The expected behavior is for the operator to just keep retrying, though. The idea being that it'll eventually get restarted due to the failing health check. The reason we retry even when the resource type doesn't exist is that it's common to deploy both the crd and the operator at the same time, so it's expected for resource endpoints to potentially appear after the operator is already started.

@psFried
Copy link
Owner

psFried commented Aug 24, 2020

I closed this when merging the PR since that addresses the immediate problem, but feel free to open a new issue if there's anything more on the error handling topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants