|
1 |
| -# Contributing to *Black* |
2 |
| - |
3 |
| -Welcome! Happy to see you willing to make the project better. Have you |
4 |
| -read the entire [user documentation](https://black.readthedocs.io/en/latest/) |
5 |
| -yet? |
| 1 | +# Contributing to _Black_ |
6 | 2 |
|
| 3 | +Welcome! Happy to see you willing to make the project better. Have you read the entire |
| 4 | +[user documentation](https://black.readthedocs.io/en/latest/) yet? |
7 | 5 |
|
8 | 6 | ## Bird's eye view
|
9 | 7 |
|
10 |
| -In terms of inspiration, *Black* is about as configurable as *gofmt*. |
11 |
| -This is deliberate. |
12 |
| - |
13 |
| -Bug reports and fixes are always welcome! Please follow the [issue |
14 |
| -template on GitHub](https://github.com/psf/black/issues/new) for best |
15 |
| -results. |
| 8 | +In terms of inspiration, _Black_ is about as configurable as _gofmt_. This is |
| 9 | +deliberate. |
16 | 10 |
|
17 |
| -Before you suggest a new feature or configuration knob, ask yourself why |
18 |
| -you want it. If it enables better integration with some workflow, fixes |
19 |
| -an inconsistency, speeds things up, and so on - go for it! On the other |
20 |
| -hand, if your answer is "because I don't like a particular formatting" |
21 |
| -then you're not ready to embrace *Black* yet. Such changes are unlikely |
22 |
| -to get accepted. You can still try but prepare to be disappointed. |
| 11 | +Bug reports and fixes are always welcome! Please follow the |
| 12 | +[issue template on GitHub](https://github.com/psf/black/issues/new) for best results. |
23 | 13 |
|
| 14 | +Before you suggest a new feature or configuration knob, ask yourself why you want it. If |
| 15 | +it enables better integration with some workflow, fixes an inconsistency, speeds things |
| 16 | +up, and so on - go for it! On the other hand, if your answer is "because I don't like a |
| 17 | +particular formatting" then you're not ready to embrace _Black_ yet. Such changes are |
| 18 | +unlikely to get accepted. You can still try but prepare to be disappointed. |
24 | 19 |
|
25 | 20 | ## Technicalities
|
26 | 21 |
|
27 |
| -Development on the latest version of Python is preferred. As of this |
28 |
| -writing it's 3.8. You can use any operating system. I am using macOS |
29 |
| -myself and CentOS at work. |
| 22 | +Development on the latest version of Python is preferred. As of this writing it's 3.8. |
| 23 | +You can use any operating system. I am using macOS myself and CentOS at work. |
30 | 24 |
|
31 | 25 | Install all development dependencies using:
|
| 26 | + |
32 | 27 | ```
|
33 | 28 | $ pipenv install --dev
|
34 | 29 | $ pipenv shell
|
35 | 30 | $ pre-commit install
|
36 | 31 | ```
|
37 |
| -If you haven't used `pipenv` before but are comfortable with virtualenvs, |
38 |
| -just run `pip install pipenv` in the virtualenv you're already using and |
39 |
| -invoke the command above from the cloned *Black* repo. It will do the |
40 |
| -correct thing. |
| 32 | + |
| 33 | +If you haven't used `pipenv` before but are comfortable with virtualenvs, just run |
| 34 | +`pip install pipenv` in the virtualenv you're already using and invoke the command above |
| 35 | +from the cloned _Black_ repo. It will do the correct thing. |
41 | 36 |
|
42 | 37 | Before submitting pull requests, run tests with:
|
| 38 | + |
43 | 39 | ```
|
44 | 40 | $ python setup.py test
|
45 | 41 | ```
|
46 | 42 |
|
47 |
| - |
48 | 43 | ## Hygiene
|
49 | 44 |
|
50 |
| -If you're fixing a bug, add a test. Run it first to confirm it fails, |
51 |
| -then fix the bug, run it again to confirm it's really fixed. |
52 |
| - |
53 |
| -If adding a new feature, add a test. In fact, always add a test. But |
54 |
| -wait, before adding any large feature, first open an issue for us to |
55 |
| -discuss the idea first. |
| 45 | +If you're fixing a bug, add a test. Run it first to confirm it fails, then fix the bug, |
| 46 | +run it again to confirm it's really fixed. |
56 | 47 |
|
| 48 | +If adding a new feature, add a test. In fact, always add a test. But wait, before adding |
| 49 | +any large feature, first open an issue for us to discuss the idea first. |
57 | 50 |
|
58 | 51 | ## Finally
|
59 | 52 |
|
60 |
| -Thanks again for your interest in improving the project! You're taking |
61 |
| -action when most people decide to sit and watch. |
| 53 | +Thanks again for your interest in improving the project! You're taking action when most |
| 54 | +people decide to sit and watch. |
0 commit comments