Apply suggestions in code review.

Co-authored-by: Sviatoslav Sydorenko <[email protected]>

Author: jaraco

changelog.d/2592.change.rst

@@ -1 +1,3 @@
-Warned for usage of uppercase keys in :code:`metadata` in :code:`setup.cfg`, restored some compatiblity by transforming to lowercase if not. Followed the change of keys in :code:`setup.cfg` now being case-sensitive -- by :user:`melissa-kun-li`
+Made option keys in the ``[metadata]`` section of ``setup.cfg`` case-sensitive. Users having
+uppercase option spellings will get a warning suggesting to make them to lowercase
+-- by :user:`melissa-kun-li`

setuptools/dist.py

@@ -599,7 +599,7 @@ def _parse_config_files(self, filenames=None):  # noqa: C901
 
                     val = parser.get(section, opt)
                     opt = self.dash_to_underscore_warning(opt, section)
-                    opt = self.uppercase_warning(opt, section)
+                    opt = self.make_option_lowercase(opt, section)
                     opt_dict[opt] = (filename, val)
 
             # Make the ConfigParser forget everything (so we retain
@@ -637,16 +637,17 @@ def dash_to_underscore_warning(self, opt, section):
                 % (opt, underscore_opt))
         return underscore_opt
 
-    def uppercase_warning(self, opt, section):
-        if section in ('metadata',) and (any(c.isupper() for c in opt)):
-            lowercase_opt = opt.lower()
-            warnings.warn(
-                "Usage of uppercase key '%s' in '%s' will be deprecated in future "
-                "versions. Please use lowercase '%s' instead"
-                % (opt, section, lowercase_opt)
-            )
-            return lowercase_opt
-        return opt
+    def make_option_lowercase(self, opt, section):
+        if section != 'metadata' or opt.islower():
+            return opt
+
+        lowercase_opt = opt.lower()
+        warnings.warn(
+            "Usage of uppercase key '%s' in '%s' will be deprecated in future "
+            "versions. Please use lowercase '%s' instead"
+            % (opt, section, lowercase_opt)
+        )
+        return lowercase_opt
 
     # FIXME: 'Distribution._set_command_options' is too complex (14)
     def _set_command_options(self, command_obj, option_dict=None):  # noqa: C901

setuptools/tests/test_config.py

@@ -541,8 +541,9 @@ def test_uppercase_warning(self, tmpdir):
         with pytest.warns(UserWarning, match=msg):
             with get_dist(tmpdir) as dist:
                 metadata = dist.metadata
-                assert metadata.name == 'foo'
-                assert metadata.description == 'Some description'
+
+        assert metadata.name == 'foo'
+        assert metadata.description == 'Some description'
 
 
 class TestOptions: