terminal: default to fE with -r (reportchars)

Fixes #6454

Author: blueyed

changelog/6454.feature.rst

@@ -0,0 +1 @@
+Changed default for `-r` to `fE`, which displays failures and errors in the :ref:`short test summary <pytest.detailed_failed_tests_usage>`.  `-rN` can be used to disable it (the old behavior).

src/_pytest/terminal.py

@@ -33,6 +33,8 @@
 
 REPORT_COLLECTING_RESOLUTION = 0.5
 
+_REPORTCHARS_DEFAULT = "fE"
+
 
 class MoreQuietAction(argparse.Action):
     """
@@ -88,12 +90,13 @@ def pytest_addoption(parser):
         "-r",
         action="store",
         dest="reportchars",
-        default="",
+        default=_REPORTCHARS_DEFAULT,
         metavar="chars",
         help="show extra test summary info as specified by chars: (f)ailed, "
         "(E)rror, (s)kipped, (x)failed, (X)passed, "
         "(p)assed, (P)assed with output, (a)ll except passed (p/P), or (A)ll. "
-        "(w)arnings are enabled by default (see --disable-warnings).",
+        "(w)arnings are enabled by default (see --disable-warnings), "
+        "'N' can be used to reset the list. (default: 'fE').",
     )
     group._addoption(
         "--disable-warnings",
@@ -169,7 +172,7 @@ def getreportopt(config: Config) -> str:
     reportopts = ""
     reportchars = config.option.reportchars
     if not config.option.disable_warnings and "w" not in reportchars:
-        reportchars += "w"
+        reportchars = "w" + reportchars
     elif config.option.disable_warnings and "w" in reportchars:
         reportchars = reportchars.replace("w", "")
     aliases = {"F", "S"}
@@ -181,7 +184,8 @@ def getreportopt(config: Config) -> str:
             reportopts = "sxXwEf"
         elif char == "A":
             reportopts = "PpsxXwEf"
-            break
+        elif char == "N":
+            reportopts = ""
         elif char not in reportopts:
             reportopts += char
     return reportopts

testing/test_terminal.py

@@ -807,9 +807,9 @@ def test():
 def test_fail_extra_reporting(testdir, monkeypatch):
     monkeypatch.setenv("COLUMNS", "80")
     testdir.makepyfile("def test_this(): assert 0, 'this_failed' * 100")
-    result = testdir.runpytest()
+    result = testdir.runpytest("-rN")
     result.stdout.no_fnmatch_line("*short test summary*")
-    result = testdir.runpytest("-rf")
+    result = testdir.runpytest()
     result.stdout.fnmatch_lines(
         [
             "*test summary*",
@@ -918,15 +918,20 @@ def test_this(i):
 
 
 def test_getreportopt():
+    from _pytest.terminal import _REPORTCHARS_DEFAULT
+
     class Config:
         class Option:
-            reportchars = ""
+            reportchars = _REPORTCHARS_DEFAULT
             disable_warnings = True
 
         option = Option()
 
     config = Config()
 
+    # Default.
+    assert getreportopt(config) == "fE"
+
     config.option.reportchars = "sf"
     assert getreportopt(config) == "sf"
 
@@ -939,7 +944,7 @@ class Option:
     assert getreportopt(config) == "sxXwEf"  # NOTE: "w" included!
 
     config.option.reportchars = "sfx"
-    assert getreportopt(config) == "sfxw"
+    assert getreportopt(config) == "wsfx"
 
     config.option.reportchars = "sfxw"
     assert getreportopt(config) == "sfxw"
@@ -950,6 +955,9 @@ class Option:
     config.option.reportchars = "A"
     assert getreportopt(config) == "PpsxXwEf"
 
+    config.option.reportchars = "AN"
+    assert getreportopt(config) == ""
+
 
 def test_terminalreporter_reportopt_addopts(testdir):
     testdir.makeini("[pytest]\naddopts=-rs")
@@ -1065,7 +1073,7 @@ def test_func():
         )
         for tbopt in ["long", "short", "no"]:
             print("testing --tb=%s..." % tbopt)
-            result = testdir.runpytest("--tb=%s" % tbopt)
+            result = testdir.runpytest("-rN", "--tb=%s" % tbopt)
             s = result.stdout.str()
             if tbopt == "long":
                 assert "print(6*7)" in s