Internal Error when rerun occurs on tests that are members of a class using mark. #3555
Comments
|
GitMate.io thinks possibly related issues are #3163 (Pytest internal error due to infinite recursion on final test), #50 (Select tests according to their mark), #3494 (Cannot select test by mark using lower case param), #120 (py.test.mark.parameterize works with test functions, but not classes), and #814 (Mark for flaky tests). |
|
Thanks @pytestbot but none of those seem relevant. (Yes, I know this is a bot). |
RonnyPfannschmidt
added
the
status: needs information
|
the issue report is incomplete, off-hand i have no idea what could be wrong please provide at least a runable example |
|
I posted the code as best I could. It is not publicly licensed. I will need to make a new repo and try to reproduce it independently. I was hoping the code above was enough for someone to tells us we are doing something wrong. |
|
@shaleh its completely unclear where the markdeorator is from without the code of the decorators as well |
|
also the missing traceback leaves no clue for a indication |
|
I did not include the traceback because it did not appear helpful. I will see what I can do about adding it. I did not think about the definition of the marker. Thank you, I will update the Issue with a recreation of it. |
|
Ok, I added more info about the marker registration. |
|
And full traceback is now included. |
|
this is a bug in custom marker application, please post the helper |
|
I do not have any special custom markers. I use the registered 'thing1' or 'thing2' nothing more.
Which helper do you need? |
|
that |
|
Thanks for the pointer. I will go look. |
Really simple. Is it supposed to take a marker parameter? What about tests without a marker? |
|
@shaleh in the integration something else is going on, please show the complete code |
|
No really, that is it :-) I pasted that directly from the real source. |
|
It just adds the id to the function. Code elsewhere assumes the function has a |
|
However, this may be relevant: |
|
that part is where the error happens, but the trigger is somewhere else, likely something with a add_marker call - i ask for the complete code there because i'm very aware of the internal interactions and dont have to guess whats relevant |
|
yeah. I understand. Thanks, I will go hunting. I appreciate the pointer. |
|
I think I have the culprit... That is in the top level conftest.py. It is the only |
RonnyPfannschmidt
added
the
type: regression
|
thanks for the update, this seems to be a regression introduced by the legacy marker support for now you have to pin the older pytest i beleive, i#ll try to come up with a minimal acceptance test later and come up with a propper solution |
RonnyPfannschmidt
removed
the
status: needs information
|
Excellent. Glad I could help! Thanks for your time. Updating our code to use |
|
@RonnyPfannschmidt is this related to #3501? I ask because the error message is the same. |
|
@nicoddemus unrelated - just triggers the same issue - the code in #3501 deliberately triggers it by putting a markdecorator into a place where only marks should be the code here doesn't |
|
I see, thanks. I still need to get back to #3501, hopefully will have time this week after a major Python 3 conversion at work. 😁 |
This PR updates [pytest](https://pypi.org/project/pytest) from **3.5.1** to **3.6.3**. <details> <summary>Changelog</summary> ### 3.6.2 ``` ========================= Bug Fixes --------- - Fix regression in ``Node.add_marker`` by extracting the mark object of a ``MarkDecorator``. (`3555 <https://github.com/pytest-dev/pytest/issues/3555>`_) - Warnings without ``location`` were reported as ``None``. This is corrected to now report ``<undetermined location>``. (`3563 <https://github.com/pytest-dev/pytest/issues/3563>`_) - Continue to call finalizers in the stack when a finalizer in a former scope raises an exception. (`3569 <https://github.com/pytest-dev/pytest/issues/3569>`_) - Fix encoding error with `print` statements in doctests (`3583 <https://github.com/pytest-dev/pytest/issues/3583>`_) Improved Documentation ---------------------- - Add documentation for the ``--strict`` flag. (`3549 <https://github.com/pytest-dev/pytest/issues/3549>`_) Trivial/Internal Changes ------------------------ - Update old quotation style to parens in fixture.rst documentation. (`3525 <https://github.com/pytest-dev/pytest/issues/3525>`_) - Improve display of hint about ``--fulltrace`` with ``KeyboardInterrupt``. (`3545 <https://github.com/pytest-dev/pytest/issues/3545>`_) - pytest's testsuite is no longer runnable through ``python setup.py test`` -- instead invoke ``pytest`` or ``tox`` directly. (`3552 <https://github.com/pytest-dev/pytest/issues/3552>`_) - Fix typo in documentation (`3567 <https://github.com/pytest-dev/pytest/issues/3567>`_) ``` ### 3.6.1 ``` ========================= Bug Fixes --------- - Fixed a bug where stdout and stderr were logged twice by junitxml when a test was marked xfail. (`3491 <https://github.com/pytest-dev/pytest/issues/3491>`_) - Fix ``usefixtures`` mark applyed to unittest tests by correctly instantiating ``FixtureInfo``. (`3498 <https://github.com/pytest-dev/pytest/issues/3498>`_) - Fix assertion rewriter compatibility with libraries that monkey patch ``file`` objects. (`3503 <https://github.com/pytest-dev/pytest/issues/3503>`_) Improved Documentation ---------------------- - Added a section on how to use fixtures as factories to the fixture documentation. (`3461 <https://github.com/pytest-dev/pytest/issues/3461>`_) Trivial/Internal Changes ------------------------ - Enable caching for pip/pre-commit in order to reduce build time on travis/appveyor. (`3502 <https://github.com/pytest-dev/pytest/issues/3502>`_) - Switch pytest to the src/ layout as we already suggested it for good practice - now we implement it as well. (`3513 <https://github.com/pytest-dev/pytest/issues/3513>`_) - Fix if in tests to support 3.7.0b5, where a docstring handling in AST got reverted. (`3530 <https://github.com/pytest-dev/pytest/issues/3530>`_) - Remove some python2.5 compatibility code. (`3529 <https://github.com/pytest-dev/pytest/issues/3529>`_) ``` ### 3.6.0 ``` ========================= Features -------- - Revamp the internals of the ``pytest.mark`` implementation with correct per node handling which fixes a number of long standing bugs caused by the old design. This introduces new ``Node.iter_markers(name)`` and ``Node.get_closest_mark(name)`` APIs. Users are **strongly encouraged** to read the `reasons for the revamp in the docs <https://docs.pytest.org/en/latest/mark.htmlmarker-revamp-and-iteration>`_, or jump over to details about `updating existing code to use the new APIs <https://docs.pytest.org/en/latest/mark.htmlupdating-code>`_. (`3317 <https://github.com/pytest-dev/pytest/issues/3317>`_) - Now when ``pytest.fixture`` is applied more than once to the same function a ``ValueError`` is raised. This buggy behavior would cause surprising problems and if was working for a test suite it was mostly by accident. (`2334 <https://github.com/pytest-dev/pytest/issues/2334>`_) - Support for Python 3.7's builtin ``breakpoint()`` method, see `Using the builtin breakpoint function <https://docs.pytest.org/en/latest/usage.htmlbreakpoint-builtin>`_ for details. (`3180 <https://github.com/pytest-dev/pytest/issues/3180>`_) - ``monkeypatch`` now supports a ``context()`` function which acts as a context manager which undoes all patching done within the ``with`` block. (`3290 <https://github.com/pytest-dev/pytest/issues/3290>`_) - The ``--pdb`` option now causes KeyboardInterrupt to enter the debugger, instead of stopping the test session. On python 2.7, hitting CTRL+C again exits the debugger. On python 3.2 and higher, use CTRL+D. (`3299 <https://github.com/pytest-dev/pytest/issues/3299>`_) - pytest not longer changes the log level of the root logger when the ``log-level`` parameter has greater numeric value than that of the level of the root logger, which makes it play better with custom logging configuration in user code. (`3307 <https://github.com/pytest-dev/pytest/issues/3307>`_) Bug Fixes --------- - A rare race-condition which might result in corrupted ``.pyc`` files on Windows has been hopefully solved. (`3008 <https://github.com/pytest-dev/pytest/issues/3008>`_) - Also use iter_marker for discovering the marks applying for marker expressions from the cli to avoid the bad data from the legacy mark storage. (`3441 <https://github.com/pytest-dev/pytest/issues/3441>`_) - When showing diffs of failed assertions where the contents contain only whitespace, escape them using ``repr()`` first to make it easy to spot the differences. (`3443 <https://github.com/pytest-dev/pytest/issues/3443>`_) Improved Documentation ---------------------- - Change documentation copyright year to a range which auto-updates itself each time it is published. (`3303 <https://github.com/pytest-dev/pytest/issues/3303>`_) Trivial/Internal Changes ------------------------ - ``pytest`` now depends on the `python-atomicwrites <https://github.com/untitaker/python-atomicwrites>`_ library. (`3008 <https://github.com/pytest-dev/pytest/issues/3008>`_) - Update all pypi.python.org URLs to pypi.org. (`3431 <https://github.com/pytest-dev/pytest/issues/3431>`_) - Detect `pytest_` prefixed hooks using the internal plugin manager since ``pluggy`` is deprecating the ``implprefix`` argument to ``PluginManager``. (`3487 <https://github.com/pytest-dev/pytest/issues/3487>`_) - Import ``Mapping`` and ``Sequence`` from ``_pytest.compat`` instead of directly from ``collections`` in ``python_api.py::approx``. Add ``Mapping`` to ``_pytest.compat``, import it from ``collections`` on python 2, but from ``collections.abc`` on Python 3 to avoid a ``DeprecationWarning`` on Python 3.7 or newer. (`3497 <https://github.com/pytest-dev/pytest/issues/3497>`_) ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pytest - Changelog: https://pyup.io/changelogs/pytest/ - Repo: https://github.com/pytest-dev/pytest/issues - Homepage: http://pytest.org </details>
(Updated, added into about the marker registration)
We have some integration tests using selenium that pytest runs for us.
When a test fails and is rerun we see this:
The tests that are being rerun are methods of a test class declared like this:
There are no marks on the fixtures. The
thing1mark is registered in pytest.ini like so:Python version
pip list says:
I am running on OSX:
Thank you.
The text was updated successfully, but these errors were encountered: