Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probably not a good idea to do SSL in server #5

Closed
diwu1989 opened this issue Jun 7, 2015 · 1 comment
Closed

Probably not a good idea to do SSL in server #5

diwu1989 opened this issue Jun 7, 2015 · 1 comment

Comments

@diwu1989
Copy link
Contributor

diwu1989 commented Jun 7, 2015

Noticed that you have

To Do:
...
SSL support in server

I don't think it's a good idea do SSL support in a web application because production web applications are deployed behind a reverse proxy that is optimized for SSL termination, such as Nginx.

You also want to:

Do one, simple thing well. There are several similar projects out there that do more than this project attempts to do.

therefore, I propose striking SSL termination out of the TODO section

@jikamens
Copy link
Collaborator

jikamens commented Jun 8, 2015

Hi,

The README also says:

Minimize external dependencies. If something is simple and straightforward to do ourselves, don't use a third-party package just for the sake of using a third-party package.

SSL is easy to do, and Coal Mine is a trivial enough application that it by no means needs to be run behind a reverse proxy to support SSL. Therefore, adding SSL support to the application is a good idea which I hope to eventually have time to implement (or I hope someone else does it and submits a PR!).

@jikamens jikamens closed this as completed Jun 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants