From e816c4f3ba16b4ec6e466d08fc8b5bb65fc0baf3 Mon Sep 17 00:00:00 2001
From: crozzy <joseph.crosland@gmail.com>
Date: Fri, 3 Jan 2025 11:38:34 -0800
Subject: [PATCH] migrations: add missing index creating migration

While the sql command was added to claircore (and the admin command was
added to clairctl) to create an index it was never actually reference in
the migrations. This should be a no-op for all instances that ran the
associated clairctl admin command. Also, added a test to try and avoid
this in the future.

Signed-off-by: crozzy <joseph.crosland@gmail.com>
---
 datastore/postgres/migrations/migrations.go   |  4 ++
 .../postgres/migrations/migrations_test.go    | 68 +++++++++++++++++++
 2 files changed, 72 insertions(+)
 create mode 100644 datastore/postgres/migrations/migrations_test.go

diff --git a/datastore/postgres/migrations/migrations.go b/datastore/postgres/migrations/migrations.go
index 9dbe7c72e..fa52113c4 100644
--- a/datastore/postgres/migrations/migrations.go
+++ b/datastore/postgres/migrations/migrations.go
@@ -57,6 +57,10 @@ var IndexerMigrations = []migrate.Migration{
 		ID: 7,
 		Up: runFile("indexer/07-index-manifest_index.sql"),
 	},
+	{
+		ID: 8,
+		Up: runFile("indexer/08-index-manifest_layer.sql"),
+	},
 }
 
 var MatcherMigrations = []migrate.Migration{
diff --git a/datastore/postgres/migrations/migrations_test.go b/datastore/postgres/migrations/migrations_test.go
new file mode 100644
index 000000000..7805b7533
--- /dev/null
+++ b/datastore/postgres/migrations/migrations_test.go
@@ -0,0 +1,68 @@
+package migrations
+
+import (
+	"bufio"
+	iofs "io/fs"
+	"os"
+	"path"
+	"path/filepath"
+	"regexp"
+	"slices"
+	"testing"
+
+	"github.com/google/go-cmp/cmp"
+)
+
+func TestMigrationsMismatch(t *testing.T) {
+	var migrations, files []string
+
+	// Get referenced migrations
+	migrationLine, err := regexp.Compile(`runFile\(\"(.*)\"\)`)
+	if err != nil {
+		t.Fatal(err)
+	}
+	f, err := os.Open("migrations.go")
+	if err != nil {
+		t.Fatal(err)
+	}
+	defer f.Close()
+
+	s := bufio.NewScanner(f)
+	for s.Scan() {
+		ms := migrationLine.FindSubmatch(s.Bytes())
+		switch {
+		case ms == nil, len(ms) == 1:
+			continue
+		case len(ms) == 2:
+			migrations = append(migrations, path.Clean(string(ms[1])))
+		}
+	}
+	if err := s.Err(); err != nil {
+		t.Error(err)
+	}
+	slices.Sort(migrations)
+
+	// Get migration files
+	err = iofs.WalkDir(os.DirFS("."), ".", func(p string, d iofs.DirEntry, err error) error {
+		switch {
+		case err != nil:
+			return err
+		case d.IsDir():
+			return nil
+		case filepath.Ext(d.Name()) != ".sql":
+			return nil
+		}
+		files = append(files, p)
+		return nil
+	})
+	if err != nil {
+		t.Error(err)
+	}
+	slices.Sort(files)
+
+	// Check referenced files exist and existing files are referenced.
+	if !cmp.Equal(migrations, files) {
+		t.Log("error mismatch of migrations to entries:")
+		t.Error(cmp.Diff(migrations, files))
+	}
+}