Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move JSON Schema parser/stuff into own package #93

Closed
davidanthoff opened this issue Jun 6, 2018 · 5 comments
Closed

Move JSON Schema parser/stuff into own package #93

davidanthoff opened this issue Jun 6, 2018 · 5 comments
Milestone

Comments

@davidanthoff
Copy link
Member

I'm not really sure this makes sense, but if the JSON schema stuff is generic enough that it is not vega-lite specific, it might make use to move it into a JSONSchema.jl package, so that other packages can also use it?

@davidanthoff davidanthoff added this to the Backlog milestone Jun 6, 2018
@fredo-dedup
Copy link
Collaborator

I have been thinking about this too. I'll give it a try.

@fredo-dedup
Copy link
Collaborator

I finished the JSONSchema package handling the JSON validation function. It is in the process of being registered.
I'd like to start the adaptation of VegaLite but I am not sure where to start. Ideally this should be on a branch compliant with julia 0.7 and 1.0.
Should I start a new branch off the current master or should I wait ? What is your advice ?

@davidanthoff
Copy link
Member Author

So what I did in the meantime is that master is julia 0.7/1.0 only. But there are still a few kinks to iron out before we can tag a version for 0.7/1.0. Maybe the best thing right now would be to wait a little, until we have tagged a version for 0.7/1.0, and then start off master?

I should also say that I currently disabled all schema checking because it had some false negatives. I think it would be good to get schema checking back in, though!

@davidanthoff
Copy link
Member Author

Alright, I think we could do this now. master is julia 0.7/1.0 only, we have tagged a release, so now might be a good time to sort this out?

@fredo-dedup
Copy link
Collaborator

Thanks David. I'll start as soon as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants