Skip to content

Commit 5ef1c54

Browse files
Apply suggestions from code review
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
1 parent 29c6440 commit 5ef1c54

File tree

6 files changed

+7
-7
lines changed

6 files changed

+7
-7
lines changed

catalog/app/containers/Bucket/Download/BucketOptions.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ interface DownloadDirProps {
3636

3737
function DownloadDir({ dirHandle }: DownloadDirProps) {
3838
return (
39-
<FileView.ZipDownloadForm suffix={`dir/${dirHandle}/${dirHandle}`}>
39+
<FileView.ZipDownloadForm suffix={`dir/${dirHandle.bucket}/${dirHandle.path}`}>
4040
<M.Button startIcon={<M.Icon>archive</M.Icon>} type="submit">
4141
Download ZIP (directory)
4242
</M.Button>
@@ -81,7 +81,7 @@ interface OptionsProps {
8181
hideCode?: boolean
8282
}
8383

84-
export default function Optiots({ handle, hideCode }: OptionsProps) {
84+
export default function Options({ handle, hideCode }: OptionsProps) {
8585
if (hideCode) return <DownloadPanel handle={handle} />
8686

8787
return (

catalog/app/containers/Bucket/Download/Button.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ const useStyles = M.makeStyles((t) => ({
1818
},
1919
},
2020
backdrop: {
21-
zIndex: t.zIndex.drawer,
21+
zIndex: t.zIndex.modal - 1,
2222
},
2323
}))
2424

catalog/app/containers/Bucket/Download/Code.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ export default function Code({ className, help, hl, label, lines }: CodeProps) {
8080
<div className={className}>
8181
<M.Typography className={classes.label} variant="subtitle2">
8282
{label}
83-
<a href={help} target="_blank" className={classes.help}>
83+
<a href={help} target="_blank" rel="noopener noreferrer" className={classes.help}>
8484
<M.IconButton size="small">
8585
<M.Icon fontSize="inherit">help</M.Icon>
8686
</M.IconButton>

catalog/app/containers/Bucket/Download/OptionsTabs.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ const useStyles = M.makeStyles((t) => ({
7474
transform: 'scaleX(0.5)',
7575
},
7676
'100%': {
77-
opacity: 'scaleX(1)',
77+
transform: 'scaleX(1)',
7878
},
7979
},
8080
}))

catalog/app/containers/Bucket/Download/PackageOptions.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ export default function Options({
167167
selection,
168168
uri,
169169
}: OptionsProps) {
170-
if (hideCode) return <DownloadPanel fileHandle={fileHandle} uri={uri} />
170+
if (hideCode) return <DownloadPanel fileHandle={fileHandle} selection={selection} uri={uri} />
171171

172172
return (
173173
<Tabs labels={['QuiltSync', 'Code']}>

catalog/app/utils/StyledTooltip.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ const useStyles = M.makeStyles((t) => ({
1616
padding: t.spacing(1),
1717
},
1818
arrow: {
19-
color: t.palette.common.white,
19+
color: t.palette.background.paper,
2020
},
2121
}))
2222

0 commit comments

Comments
 (0)