Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calling the read_fun function in box_read() #115

Open
ijlyttle opened this issue Aug 3, 2019 · 0 comments
Open

calling the read_fun function in box_read() #115

ijlyttle opened this issue Aug 3, 2019 · 0 comments

Comments

@ijlyttle
Copy link
Member

ijlyttle commented Aug 3, 2019

boxr/R/boxr_read.R

Lines 86 to 91 in 30a9275

if ("format" %in% names(formals(read_fun))) {
cont <- read_fun(new_name, format = ext, ...)
} else {
# Otherwise, just try and read it with a user-supplied function
cont <- read_fun(new_name, ...)
}

The names(formals(read_fun)) part bothers me a bit - it assumes that if read_fun has a format argument, that it will mean the same thing as in rio::import().

I don't plan to address this in this release, but I'd like to come back to it at some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant