Skip to content

Commit c782cd3

Browse files
StevenMMortimerjimhester
authored andcommitted
Remove args argument
Remove the args argument because it is blocking the user from passing args down into the install command
1 parent 3dbef06 commit c782cd3

File tree

3 files changed

+4
-11
lines changed

3 files changed

+4
-11
lines changed

NEWS.md

+2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# devtools 1.13.0
22

3+
* Remove deprecated `args` argument from `install_git()` to allow passthrough to `install` (#1373, @ReportMort).
4+
35
* added a `quiet` argument to `install_bitbucket()`, with a default value
46
of `FALSE` (fixes issue #1345, @plantarum).
57

R/install-git.r

+1-6
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010
#' @param branch Name of branch or tag to use, if not master.
1111
#' @param credentials A git2r credentials object passed through
1212
#' to \code{\link[git2r]{clone}}.
13-
#' @param args DEPRECATED. A character vector providing extra arguments to
14-
#' pass on to git.
1513
#' @param ... passed on to \code{\link{install}}
1614
#' @export
1715
#' @family package installation
@@ -20,10 +18,7 @@
2018
#' install_git("git://github.com/hadley/stringr.git")
2119
#' install_git("git://github.com/hadley/stringr.git", branch = "stringr-0.2")
2220
#'}
23-
install_git <- function(url, subdir = NULL, branch = NULL, credentials = NULL,
24-
args = character(0), ...) {
25-
if (!missing(args))
26-
warning("`args` is deprecated", call. = FALSE)
21+
install_git <- function(url, subdir = NULL, branch = NULL, credentials = NULL, ...) {
2722

2823
remotes <- lapply(url, git_remote, subdir = subdir,
2924
branch = branch, credentials=credentials)

man/install_git.Rd

+1-5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)