absence of hooks directory is not definitive test for git repo

[jennybc]

I confess: I created a git repo using sourcetree instead of git init or RStudio. Apparently this can lead to a repo in which the .git directory does not contains a hooks subdirectory. Even after you've made a commit. So when I attempt to use devtools::use_readme_rmd(), I hit this code in use_git_hook() and get Error: This project doesn't use git. Apparently there are other ways to have a valid git repo and yet NOT have a hooks subdirectory.

I admit this maybe a rare phenomenon. Not sure if a different error message is the way to go or just outright creation of hooks.

[jennybc]

FWIW, from reading Git docs and my own experience, it seems perfectly OK to create the .git/hooks subdirectory de novo and carry on.

[hadley]

Agreed. Want to do a PR or want me to do it?

[jennybc]

I am happy either way. Was planning to PR this after the one other played itself out. This is much smaller thing.

[lock]

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/