Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing_argument_linter() misses S4 usage #2820

Open
MichaelChirico opened this issue Mar 7, 2025 · 0 comments
Open

missing_argument_linter() misses S4 usage #2820

MichaelChirico opened this issue Mar 7, 2025 · 0 comments

Comments

@MichaelChirico
Copy link
Collaborator

Uncovered by #2191

lint(text = "obj$get(a =)", linters = missing_argument_linter())

The reason is that get is not a <SYMBOL_FUNCTION_CALL> in the AST -- it's a <SLOT>! (TIL)

We might need to consider more broadly which //SYMBOL_FUNCTION_CALL linters also apply when the call is a //SLOT.

We do so in one place so far:

| //OP-AT/following-sibling::SLOT[starts-with(text(), '`')]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant