-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to update the site for released version of a package #1950
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
As I refined my process, I realized it would be best to build the updated site on GHA. As I thought about what such an action needed to do, I realized the existing So THAT is what we need to document! on:
push:
branches: [main, master]
tags: ['*'] The It's possible we should make the triggering Workflow syntax for Create a branch based on the most recent CRAN release. This example is from vroom.
Substitute the tag of the most recent released version and change the branch name accordingly. Push this branch to GitHub.
Create a tag at
This will trigger our pkgdown GHA workflow and, since the version in |
I'm not sure we want to encourage people to use tags in this way; it feels like using a side-effect of making a tag. Maybe we can add some other trigger? We definitely should restrict the default tag building: r-lib/actions#450 |
This discussion unfolded further in r-lib/actions#450 and r-lib/actions#451. The end result is that our pkgdown GHA workflow now looks more like this:
The
|
Given the changes to the action, does pkgdown need to do anything? |
I think this has become a documentation problem. I still think we should record that, if you're using our GHA workflow, you can trigger an update of the released site via the |
Hmmm maybe we need a "publishing" vignette that could cover this (and more). I won't work on it for the next patch release, but we should do at some point in the future. |
Sounds good. I feel like vignettes are basically decoupled from the release cycle anyway, esp. for a web-oriented package. |
I'm using
more often these days, which means there's two version of the site, e.g. one for the released version of the package https://gmailr.r-lib.org and another for the development version of the package https://gmailr.r-lib.org/dev/.
But sometimes you need to update the released site, even though the package version in current source has already advanced to a development version. My most recent example was needing to backport some documentation changes and pkgdown config fixes to gmailr's released site.
This issue is a reminder to us to document how to do this.
UPDATE: I gradually realized that our existing pkgdown GHA workflow is capable of doing this. You just need to create a branch that reflects the source state you want to pkgdown-render from
and push a tag pointing to that ref. I'm going to delete or hide the notes about my journey to this realization. Update: read on for what to do with this branch.The text was updated successfully, but these errors were encountered: