Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print an account of test statuses #106

Open
topepo opened this issue Apr 23, 2019 · 9 comments
Open

Print an account of test statuses #106

topepo opened this issue Apr 23, 2019 · 9 comments
Labels

Comments

@topepo
Copy link
Member

topepo commented Apr 23, 2019

When running R CMD check it would be good to know how many tests were skipped even if there are no failures.

@gaborcsardi
Copy link
Member

This is more of an issue for rcmdcheck I think.

@gaborcsardi gaborcsardi transferred this issue from r-lib/testthat Apr 23, 2019
@jennybc
Copy link
Member

jennybc commented Apr 23, 2019

Specifically, I'd rejoice if this:

* checking tests ...
  Running ‘testthat.R’
 OK

got an upgrade to include more of this:

══ Results ══════════════════════
Duration: 14.7 s

OK:       390
Failed:   0
Skipped:  3

@gaborcsardi
Copy link
Member

OK, so this is actually a bit more involved, because parsing this information from the test results is not reliable, it depends on the reporter you are using.

Ideally, we would get the results directly from testthat, as an R object: r-lib/testthat#875

Until that is done, I'll have to postpone this.

@gaborcsardi gaborcsardi removed this from the 1.3.3 milestone May 7, 2019
@hadley
Copy link
Member

hadley commented Sep 16, 2021

Can we easily add extra data here? Maybe this should be done more from the testthat side? (i.e. what could test_check() emit to display extra info here?)

@gaborcsardi
Copy link
Member

I think that with the printing of the test results on GHA (and optionally locally as well), this is not so important any more. Locally you can always look at the .Rout file if you are interested. No?

@gaborcsardi
Copy link
Member

OTOH, we could still add some reporting to testthat, I think that would open up some new possibilties. E.g. testthat could write a summary of the results to a file in some format, if an env var is set?

@hadley
Copy link
Member

hadley commented Sep 16, 2021

I think this is really just a duplicate of #121

@gaborcsardi
Copy link
Member

Yeah, I closed that one, this one is older and has more participants.

@hadley
Copy link
Member

hadley commented Apr 26, 2022

I think this is still important; it'd be really nice to be able to see the number of skipped tests without having to dig down further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants