Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_test_fail() failure on R devel #183

Open
dhersz opened this issue Jul 15, 2022 · 1 comment
Open

get_test_fail() failure on R devel #183

dhersz opened this issue Jul 15, 2022 · 1 comment
Labels
bug an unexpected problem or unintended behavior

Comments

@dhersz
Copy link

dhersz commented Jul 15, 2022

Hi. I just changed the checking CI on a package I'm writing and I stumbled upon what seems to be a rcmdcheck error.

You can see on line 101 of the action log here the error message:

 Error in dir(path, pattern = "^tests") : 
  translating strings with "bytes" encoding is not allowed
Calls: <Anonymous> ... get_test_fail -> get_test_output -> file.path -> dir

This seems to be the offending line of code, in get_test_output():

test_path <- file.path(path, dir(path, pattern = "^tests"))

I'm not really sure what is the source of error here, but I suspect it relates to recent regular expression changes that have been going on in R devel?

Happy to help with anything. Cheers.

@gaborcsardi
Copy link
Member

Thanks! AFAICT that change was reverted, so everything should be fine soonish: wch/r-source@ef0a4a2

We can keep this issue open, we might as well work around this at the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants