Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REQUEST: Approver for superbeeny #76

Open
4 tasks done
superbeeny opened this issue Jan 29, 2025 · 3 comments
Open
4 tasks done

REQUEST: Approver for superbeeny #76

superbeeny opened this issue Jan 29, 2025 · 3 comments

Comments

@superbeeny
Copy link

superbeeny commented Jan 29, 2025

GitHub Username

@superbeeny

Requirements

List of contributions to the Radius project

fixing issues with AKS deployments
Adding credential generation and secret for postgres db
Features/superbeeny/postgreschart #8072
Installing the Dapr Helm Chart via the CLI
Fixes #7391 - fixing error in rad group show for no args
Adding Kubernetes native secrets to secret stores
fixes #7592 - adding typed to mockgen
Superbeeny/adding podspec secrets
Fixes #7561 - adding side effect import of kubernetes auth plugins.
Fixes #1205 - updating bicep files for new container environment vari…

Repos/Access
/radius APPROVER
/docs APPROVER
/samples APPROVER

AB#14233

@willtsai
Copy link
Contributor

willtsai commented Jan 29, 2025

I support and sponsor this request for the radius and docs repositories.

*update: I can also speak on behalf of docs - please also provide additional PRs (at least 5) for which you provided reviews before we may approve.

@sylvainsf
Copy link

sylvainsf commented Feb 3, 2025

Super excited to see all your contributions! After some discussion there's some depth we are looking for in reviewing other people's PRs. Can you take some time to provide some feedback to other PRs and link them here? We can revisit once you've had a chance to submit 5 substantial reviews in the Radius repo.

@willdavsmith
Copy link

I support this request for the samples repository.

Currently most of the changes to this repo are test automation updates and the like, but as we grow we'll be getting a lot more samples and updates to our current ones due to new features. When I see some interesting PRs I'll loop you in @superbeeny . Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants