-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release a new version that supports Rails 7.1 #249
Comments
We'd like to get the build pipeline to work (ideally via GitHub Action) and for the specs to pass before cutting a new version. Any help would be appreciated! |
I could help with the testing pipeline on GitHub Actions. I built a testing pipeline also with Appraisal against different Rails and Ruby versions over at https://github.com/simplificator/keycloak_oauth/blob/main/.github/workflows/tests.yml. From what I can see, we would likely need to test the different combinations of:
regarding MySQL: will you still support 5.7 (end of life since October 2023) or only 8.0+? what about MariaDB? |
Wow thank you so much @andyundso! Re: MySQL, I don't work with it myself and have no means to test it in production, but if 5.7 is past its EOL, let's drop it. We'll only support MariaDB if someone is able to add it and help support it like has been started for trilogy |
well, then #250 should contain everything needed. it just tests one version of Postgres (v14, since the Ubuntu Runner on GitHub Actions ships with the v14 version of the Postgres client). Also, the JRuby tests fail currently, not sure if those should be skipped for now or you want to merge the PR as-is. |
I tracked down the jruby issues in today and added them to #251 |
Merging #251 to resolve this issue because it has passing tests, parity for rails/ruby version coverage to #250, and doesn't introduce a new gem. The fix for the tests in JRuby is good from my point of view; since we're manipulating the resulting strings, we would never want the double quotes to be present |
Reopening until the release is actually available! |
Released! https://rubygems.org/gems/ros-apartment |
Hello, I don't want to be annoying, but I'm curious about when a new version will be released. Previously, it was stated here:
It has been a month since then. Is it more stable now?
The text was updated successfully, but these errors were encountered: