Skip to content
This repository was archived by the owner on May 25, 2021. It is now read-only.

Angular 5 does not work #1255

Closed
splincode opened this issue Dec 7, 2017 · 25 comments
Closed

Angular 5 does not work #1255

splincode opened this issue Dec 7, 2017 · 25 comments

Comments

@splincode
Copy link

Angular Version: 5.0.5

I open Augury and everything hangs and breaks:

zone.js:196 Uncaught TypeError: Cannot read property 'filter' of undefined
    at backend.js:9153
    at Array.map (<anonymous>)
    at getDependencies (backend.js:9152)
    at Object.exports.transform (backend.js:9073)
    at backend.js:9080
    at Array.forEach (<anonymous>)
    at transformChildren (backend.js:9079)
    at Object.exports.transform (backend.js:9095)
    at backend.js:9080
    at Array.forEach (<anonymous>)

Augury version (required): last
Angular version (required): last
OS: windows 7

@jgill248
Copy link

jgill248 commented Dec 8, 2017

I get the same error.

@idanb11
Copy link

idanb11 commented Dec 8, 2017

👍

@santiago-elustondo
Copy link
Contributor

Can you link to an example repository where this issue occurs?

@zoharyosef
Copy link

I presume it happens on very large projects.
Ill try to make a plunkr or something

@chami007
Copy link

chami007 commented Jan 8, 2018

same issue here. any updates ?

@splincode
Copy link
Author

splincode commented Jan 8, 2018

yes, it stayed the same

@Tsuki
Copy link

Tsuki commented Jan 18, 2018

It is from chrome-extension://elgalmkoelokbchhkhacckoklkejnhcd/build/backend.js:sourcemap
Which is Angury

@etherwizard
Copy link

This happens immediately after Augury gets two levels deep in analyzing the app component structure.

@zoharyosef
Copy link

I've tried 1.15 on my app (pretty big one)
and it still doesn't work 😭

@alonstar
Copy link

I have the same error, too.
angular v 5.2.1
chrome 64bit 64.0.3282.119

zone.js:192 Uncaught TypeError: Cannot read property 'filter' of undefined
	at backend.js:9584
	at Array.map (<anonymous>)
	at getDependencies (backend.js:9583)
	at Object.exports.transform (backend.js:9504)
	at backend.js:9511
	at Array.forEach (<anonymous>)
	at transformChildren (backend.js:9510)
	at Object.exports.transform (backend.js:9526)
	at backend.js:9511
	at Array.forEach (<anonymous>)

@tinki007
Copy link

The problem occurs also on small applications (2 views. less than 10 components). Error description is the same as described above.

@gameboyzone
Copy link

Angular 5 support provided in version 1.15.0. Just update the extension or uninstall/reinstall the extension. I did a small check on my SPA with 1 views and 2 components and it worked fine so not sure about production level apps on Angular 5 as of now. Hope this update helps!

-- New in version 1.15.0

  • Support for Angular 5

@zoharyosef
Copy link

@gameboyzone as i said, i tried V15 and it still didn't work.

@andrewthauer
Copy link
Contributor

@zoharyosef: Are you getting the same error as @splincode initially indicated? If not, would you mind posting any errors along with other relevant information to help diagnosis the problem?

@santiago-elustondo
Copy link
Contributor

Currently building out some diagnostic tools that will allow us to see where Augury is failing for you, as we are not able to replicate a lot of these issues.
We hope to be able to resolve these and other bugs very soon.
You may follow the development of this feature here: #1272

@santiago-elustondo
Copy link
Contributor

Anyone who is still having this issue: can you try using the Canary Build ?
Does the problem persist there, or is it resolved for you?

@zoharyosef
Copy link

Will try and update...
Thanks!

@zoharyosef
Copy link

Still the same problem,
the state tab doesn't show any component variables or anything...
let it be noted that i'm using it in an internal network, no access to the internet.
is it possible that some initialization that depends on an internet resource prevents Augury from functioning properly?

@m-przybylski
Copy link

m-przybylski commented Mar 27, 2018

I spend some time to debug the issue by myself. I don't know how to fix it so I'm not able to provide PR. It happens when you use combination of @Inject decorator and forwardRef() in constructor. It happens to me when I use Menu component from PrimeNG library link.
This function returns empty array and this one cannot determine what is the type so it tries to get information from decorators and that is the point where it crush.

@splincode
Copy link
Author

@santiago-elustondo Yes, I only see problems with Primeng

@santiago-elustondo
Copy link
Contributor

santiago-elustondo commented Mar 28, 2018

@m-przybylski, thanks a lot your insight. None of our example apps used forwardRef(). Ive added PrimeNG, specifically the Menu component to our demo testing app.
@m-przybylski, @splincode, @zoharyosef, can you update your Canary Build and check if the problem has gone away for you?

@m-przybylski
Copy link

Thank you @santiago-elustondo for an update. I have spotted also one more problem. When you mix optional parameter and not optional it also breaks. An example is growl component from PrimeNg. It works fine if there is only one dependency with optional decorator provided however if there are multiple @optional() decorators it breaks. I know that there are a lot of edge cases to cover.

@santiago-elustondo
Copy link
Contributor

@m-przybylski, thanks again for your help. Much appreciated.

I've added PrimeNG's Growl to our testing repo and published another version of the Canary Build (version 1.15.5).

Please let us know if you come across other such cases.

We're in the process of refactoring and standardizing Augury's data extraction services. Hopefully once we have coverage over these edge cases, they will not be a problem again in future releases of Angular.

@m-przybylski
Copy link

@santiago-elustondo UR my hero. Thank you for your help. Everything works just fine for me.

@splincode
Copy link
Author

Problem resolved

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests