You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks! Looks like there eigenvectors were already sorted in all the unit tests which is why this wasn't caught in the unit tests. I think this is guaranteed in SVD but not necessarily in np.eig. Will fix it, many thanks!
mlxtend/mlxtend/feature_extraction/principal_component_analysis.py
Lines 143 to 153 in a4bcab8
Because the column v[:,i] is the eigenvector,
mlxtend/mlxtend/feature_extraction/principal_component_analysis.py
Line 152 in a4bcab8
should be
The text was updated successfully, but these errors were encountered: