Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pre-commit hooks #944

Closed
rasbt opened this issue May 24, 2022 · 0 comments · Fixed by #950
Closed

Improve pre-commit hooks #944

rasbt opened this issue May 24, 2022 · 0 comments · Fixed by #950

Comments

@rasbt
Copy link
Owner

rasbt commented May 24, 2022

As mentioned by @labdmitriy in #915, there might be an overhaul of the pre-commit hooks necessary

The specified order in pre-commit hook is black-flake8-isort, but probably black-isort-flake8 will be more correct?
flake8 has 3 somewhat different configurations (.flake8, pre-commit hook and CI).

@rasbt rasbt mentioned this issue Jun 8, 2022
@rasbt rasbt closed this as completed in #950 Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant