[RayService] Unify the cluster switch over logic together

[kevin85421]

Search before asking

• I had searched in the issues and found no similar feature requirement.

Description

Currently, the cluster switch-over logic is split into four parts:

• promotePendingClusterToActiveCluster: Sets the RayService status
• reconcileServices: Switches the head service to the new cluster
• reconcileServices: Switches the serve service to the new cluster
• Updates the CR status

However, the dependencies between these parts are not easy to identify. For example, the following logic depends on promotePendingClusterToActiveCluster, but this dependency is not clearly defined.

kuberay/ray-operator/controllers/ray/rayservice_controller.go

Line 1035 in 7ef5654

if newSvc.Spec.Selector[utils.RayClusterLabelKey] == oldSvc.Spec.Selector[utils.RayClusterLabelKey] {

Solution: Unify the logic of setting RayService CR status, update CR status, and switch head / serve svc to the new cluster in a single function.

Use case

No response

Related issues

No response

Are you willing to submit a PR?

• Yes I am willing to submit a PR!

[kevin85421]

/assign @rueian

[rueian]

🆗