Skip to content

Commit 21d0c22

Browse files
authored
fix(android): remove unnecessary getViewManagers overrides (#1186)
1 parent 84194d8 commit 21d0c22

File tree

4 files changed

+8
-12
lines changed

4 files changed

+8
-12
lines changed

.changeset/many-pianos-guess.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@react-native-async-storage/async-storage": patch
3+
---
4+
5+
Remove unnecessary `getViewManagers` overrides

packages/default-storage/android/src/javaPackage/java/com/reactnativecommunity/asyncstorage/AsyncStoragePackage.java

+1-6
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,6 @@
3131
)
3232
public class AsyncStoragePackage extends TurboReactPackage {
3333

34-
@Override
35-
protected List<ModuleSpec> getViewManagers(ReactApplicationContext reactContext) {
36-
return null;
37-
}
38-
3934
@Override
4035
public NativeModule getModule(String name, @Nonnull ReactApplicationContext reactContext) {
4136
switch (name) {
@@ -95,4 +90,4 @@ public Map<String, ReactModuleInfo> getReactModuleInfos() {
9590
public List<ViewManager> createViewManagers(ReactApplicationContext reactContext) {
9691
return Collections.emptyList();
9792
}
98-
}
93+
}

packages/default-storage/android/src/kotlinPackage/java/com/reactnativecommunity/asyncstorage/AsyncStoragePackage.kt

+1-3
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,4 @@ class AsyncStoragePackage : TurboReactPackage() {
5050
throw RuntimeException("No ReactModuleInfoProvider for AsyncStoragePackage$\$ReactModuleInfoProvider", e)
5151
}
5252
}
53-
54-
override fun getViewManagers(reactContext: ReactApplicationContext?): MutableList<ModuleSpec>? = null
55-
}
53+
}

packages/default-storage/example/android/gradle.properties

+1-3
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,7 @@ org.gradle.jvmargs=-Xmx2g -XX:MaxMetaspaceSize=512m -XX:+HeapDumpOnOutOfMemoryEr
2525
# https://developer.android.com/topic/libraries/support-library/androidx-rn
2626
android.useAndroidX=true
2727
# Automatically convert third-party libraries to use AndroidX
28-
android.enableJetifier=true
29-
# Jetifier randomly fails on these libraries
30-
android.jetifier.ignorelist=hermes-android
28+
android.enableJetifier=false
3129

3230
# Use this property to specify which architecture you want to build.
3331
# You can also override it from the CLI using

0 commit comments

Comments
 (0)