React Fiber support

[maschwenk]

It appears that this library is not compatible with React Fiber. It is using some deprecated/removed React API's. Are there any plans in place to get start this work? Curious how much work is involved.

facebook/react#10294 (comment)

[diasbruno]

@maschwenk Yeah, that's for sure. Thanks for the link and PRs are always welcome.

[maschwenk]

Initial investigation shows that we need to replace unstable_renderSubtreeIntoContainer with unstable_createPortal. React maintainer details it here: facebook/react#9808 (comment) and provided this fiddle https://jsfiddle.net/r442t0mk/

[sandys]

we are also getting impacted by this issue.

[diasbruno]

@maschwenk @sandys I'll merge this issue with @amannn's issue #498 to tackle this. Perhaps, we can open a project and make a roadmap for the next version.

[diasbruno]

[email protected] is available.

Version 2.3.3 is the stable version and can be installed with react-modal@latest.

To use the compatible version with React 16, you can install by running npm install react-modal@next.

[merlinstardust]

Why use unstable_createPortal? Why not use ReactDOM.createPortal?

https://egghead.io/lessons/react-render-elements-outside-the-current-react-tree-using-portals-in-react-16

[diasbruno]

@merlinpatt I think this was before createPortal got in the API.

[diasbruno]

Released official v3.0.0.

You can follow #498 for more information.

Thank you all.