Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect behavior of ReadOnlyPropertyRector #8887

Closed
hildebro opened this issue Nov 6, 2024 · 0 comments · Fixed by rectorphp/rector-src#6411
Closed

Incorrect behavior of ReadOnlyPropertyRector #8887

hildebro opened this issue Nov 6, 2024 · 0 comments · Fixed by rectorphp/rector-src#6411
Labels

Comments

@hildebro
Copy link

hildebro commented Nov 6, 2024

Bug Report

Subject Details
Rector version last dev-main
Installed as composer dependency

Minimal PHP Code Causing Issue

See https://getrector.com/demo/0f75cc8c-f44e-47f7-81ea-5df71c8c2bfc

<?php

use Doctrine\ORM\Mapping\Embeddable;

#[Embeddable]
class DemoFile
{
    #[ORM\Column]
    private int $amount;
    
    public function __construct(int $amount)
    {
        $this->amount = $amount;
    }
}

Responsible rules

  • ReadOnlyPropertyRector

Expected Behavior

Rule should not apply. I think Embeddable is just missing from \Rector\NodeManipulator\PropertyManipulator::DOCTRINE_PROPERTY_ANNOTATIONS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant