install only if not already defined

single space

change with unless

fixed package arrays loop for install and client

Author: Doninelli Davide

manifests/client.pp

@@ -20,12 +20,19 @@
   Stdlib::Ensure::Package $package_ensure = $samba::package_ensure,
 ) {
   if $package_manage {
-    package { $packages[client]:
-      ensure => $package_ensure,
+    $samba::packages[client].each |String $package_name| {
+      unless defined(Package[$package_name]) {
+        package { $package_name:
+          ensure => $package_ensure,
+        }
+      }
     }
-
-    package { $packages[utils]:
-      ensure => $package_ensure,
+    $samba::packages[utils].each |String $package_name| {
+      unless defined(Package[$package_name]) {
+        package { $package_name:
+          ensure => $package_ensure,
+        }
+      }
     }
   }
 }

manifests/install.pp

@@ -4,12 +4,19 @@
   assert_private("Use of private class ${name} by ${caller_module_name}")
 
   if $samba::package_manage {
-    package { $samba::packages[server]:
-      ensure => $samba::package_ensure,
+    $samba::packages[server].each |String $package_name| {
+      unless defined(Package[$package_name]) {
+        package { $package_name:
+          ensure => $samba::package_ensure,
+        }
+      }
     }
-
-    package { $samba::packages[utils]:
-      ensure => $samba::package_ensure,
+    $samba::packages[utils].each |String $package_name| {
+      unless defined(Package[$package_name]) {
+        package { $package_name:
+          ensure => $samba::package_ensure,
+        }
+      }
     }
   }
 }