Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev_v2 does not recognize decorators and results in an error during compilation #7011

Closed
1 task done
lvisb opened this issue Jul 31, 2023 · 3 comments · Fixed by #7176
Closed
1 task done

dev_v2 does not recognize decorators and results in an error during compilation #7011

lvisb opened this issue Jul 31, 2023 · 3 comments · Fixed by #7176
Assignees
Labels
bug Something isn't working package:dev

Comments

@lvisb
Copy link

lvisb commented Jul 31, 2023

What version of Remix are you using?

1.19.1

Are all your remix dependencies & dev-dependencies using the same version?

  • Yes

Steps to Reproduce

In the future version of Remix Dev, decorators are not being recognized and prevent the project from being compiled, resulting in an error.

  1. clone the repo: https://github.com/lvisb/remix-v2-dev-decorators-error
  2. npm install
  3. npm run dev

remix-error-print

Expected Behavior

In version 1, it works correctly.

Actual Behavior

It results in an error and a suggestion to add the @babel/plugin-proposal-decorators.

@zhangfisher
Copy link

zhangfisher commented Aug 3, 2023

This issue did not occur in v1.18.1

@brophdawg11 brophdawg11 added this to v2 Aug 3, 2023
@brophdawg11 brophdawg11 moved this to Backlog in v2 Aug 3, 2023
@pcattori pcattori added bug Something isn't working and removed bug:unverified labels Aug 15, 2023
@pcattori pcattori moved this from Backlog to In progress in v2 Aug 15, 2023
@pcattori pcattori linked a pull request Aug 15, 2023 that will close this issue
@pcattori pcattori moved this from In progress to PR in v2 Aug 15, 2023
@pcattori pcattori moved this from PR to Closed in v2 Aug 15, 2023
@pcattori
Copy link
Contributor

Fixed by #7176

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-96b05af-20230816 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package:dev
Projects
No open projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

4 participants