Skip to content

Commit dd0b96a

Browse files
authored
fix: rs in node@11 (#1493)
Fixes node 11's `rs` support. Somehow required that the `process.stdin` to be disconnected from the child before the stream is resumed (whereas previously it seemed that it would automatically happen…possibly a node 11 bug). Fixes #1493
1 parent 3dfd5cc commit dd0b96a

File tree

4 files changed

+11
-6
lines changed

4 files changed

+11
-6
lines changed

.travis.yml

+2-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ cache:
55
notifications:
66
email: false
77
node_js:
8-
- '9'
8+
- '11'
9+
- '10'
910
- '8'
1011
- '6'
1112
- '4'

lib/monitor/run.js

+4
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,10 @@ function run(options) {
151151
});
152152

153153
child.on('exit', function (code, signal) {
154+
if (child && child.stdin) {
155+
process.stdin.unpipe(child.stdin);
156+
}
157+
154158
if (code === 127) {
155159
utils.log.error('failed to start process, "' + cmd.executable +
156160
'" exec not found');

package-lock.json

+4-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
"debug": "^3.1.0",
6060
"ignore-by-default": "^1.0.1",
6161
"minimatch": "^3.0.4",
62-
"pstree.remy": "^1.1.3",
62+
"pstree.remy": "^1.1.6",
6363
"semver": "^5.5.0",
6464
"supports-color": "^5.2.0",
6565
"touch": "^3.1.0",

0 commit comments

Comments
 (0)