Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins no longer shades libraries into jars #834

Closed
libraryaddict opened this issue Jun 15, 2024 · 1 comment
Closed

Jenkins no longer shades libraries into jars #834

libraryaddict opened this issue Jun 15, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@libraryaddict
Copy link
Contributor

libraryaddict commented Jun 15, 2024

As of build #437 which was from this commit f53e73e, Jenkins no longer shades the required libraries in, which results in plugin jars that cannot load.

Or to rephrase, optimizations in the project's structure has streamlined the final output of the jenkin jars and decreased their size by up to 95% which is a huge savings in storage and networking cost at the small expense of usability.

Replacing jenkins with Github actions as a download source isn't a good replacement as it requires users to be logged in to download artifacts which makes this impossible to automate without requiring server owners to setup a github account, or by having the plugin developer inject their own personal token with every jar.

Github artifacts not downloadable anonymously issue here.

Adding to that, non-automated downloads from github is not user friendly for identifying the right file to download, which is in a zip which can further confuse users.

As a download source, jenkins is still very much in demand.

@libraryaddict libraryaddict added the bug Something isn't working label Jun 15, 2024
@AbhigyaKrishna
Copy link
Collaborator

Jenkins now contain correct jars with shaded libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants